From owner-freebsd-arch@FreeBSD.ORG  Mon Feb 11 09:50:12 2013
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 36670ACA
 for <freebsd-arch@freebsd.org>; Mon, 11 Feb 2013 09:50:12 +0000 (UTC)
 (envelope-from christoph.mallon@gmx.de)
Received: from mout.gmx.net (mout.gmx.net [212.227.17.20])
 by mx1.freebsd.org (Postfix) with ESMTP id C93EC1781
 for <freebsd-arch@freebsd.org>; Mon, 11 Feb 2013 09:50:11 +0000 (UTC)
Received: from mailout-de.gmx.net ([10.1.76.17]) by mrigmx.server.lan
 (mrigmx002) with ESMTP (Nemesis) id 0Lkmp0-1Uezea33My-00aWIP for
 <freebsd-arch@FreeBSD.org>; Mon, 11 Feb 2013 10:50:04 +0100
Received: (qmail invoked by alias); 11 Feb 2013 09:50:04 -0000
Received: from p5B1326F3.dip.t-dialin.net (EHLO rotluchs.lokal) [91.19.38.243]
 by mail.gmx.net (mp017) with SMTP; 11 Feb 2013 10:50:04 +0100
X-Authenticated: #1673122
X-Provags-ID: V01U2FsdGVkX188hzt3G948U/lJO1agqforfrE4JWWM5G2cbFXSoy
 i9EYD6wb+LRe/G
Message-ID: <5118BEC9.1090708@gmx.de>
Date: Mon, 11 Feb 2013 10:50:01 +0100
From: Christoph Mallon <christoph.mallon@gmx.de>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130129 Thunderbird/17.0.2
MIME-Version: 1.0
To: Alfred Perlstein <bright@mu.org>
Subject: Re: Proposal: Unify printing the function name in panic messages()
References: <51141E33.4080103@gmx.de> <511426B8.2070800@FreeBSD.org>
 <51160E06.1070404@gmx.de> <20130209195417.C1753@besplex.bde.org>
 <51161C10.9070002@gmx.de> <5116504A.7010409@mu.org>
In-Reply-To: <5116504A.7010409@mu.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
Cc: Kirk McKusick <mckusick@mckusick.com>, freebsd-arch@FreeBSD.org
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2013 09:50:12 -0000

(Alfred accidently only replied to me.)

On 09.02.2013 14:34, Alfred Perlstein wrote:
> On 2/9/13 1:51 AM, Christoph Mallon wrote:
>> As bde points out, optimisations interfere with location information gathered at runtime.
>> Having the right name of the function in the panic, ensures that at least the starting point is right.
>> My PANIC() macro guarantees exactly this.
> 
> I like this fix, my only nit is asthetics.
> 
> Would we just turn panic() into a macro instead of making PANIC() everywhere in the kernel?
> 
> Too many uppercase macros are hard on the eyes.

This is a good point.
I will adjust the patches accordingly.

	Christoph