From owner-cvs-src@FreeBSD.ORG Wed Jun 2 00:04:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5503F16A4CE; Wed, 2 Jun 2004 00:04:22 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5300E43D54; Wed, 2 Jun 2004 00:04:22 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5274Mm0059018; Wed, 2 Jun 2004 00:04:22 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5274MMO059017; Wed, 2 Jun 2004 00:04:22 -0700 (PDT) (envelope-from phk) Message-Id: <200406020704.i5274MMO059017@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 2 Jun 2004 00:04:21 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/alpha/alpha pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2004 07:04:22 -0000 phk 2004/06/02 00:04:21 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/alpha/alpha pmap.c sys/i386/i386 pmap.c Log: There is a comma missing in the table initializing the pmap_prefault_pageorder array. This has two effects: 1. The resulting bogus contents of the array thwarts part of the optimization effect pmap_prefault() is supposed to have. 2. The resulting array is only 7 elements long (auto-sized), while pmap_prefault() expects it to be the intended 8 elements. So this function in fact accesses memory beyond the end of the array. Fortunately though, if the data at this location is out of bounds it will be ignored. This bug dates back more than 6 years. It has been introduced in revision 1.178. Submitted by: Uwe Doering PR: 67460 Revision Changes Path 1.35.2.11 +1 -1 src/sys/alpha/alpha/pmap.c 1.250.2.26 +1 -1 src/sys/i386/i386/pmap.c