From owner-svn-ports-all@FreeBSD.ORG Sun Nov 25 10:08:29 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A1E1D118; Sun, 25 Nov 2012 10:08:29 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-ea0-f182.google.com (mail-ea0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id 9E0A18FC12; Sun, 25 Nov 2012 10:08:28 +0000 (UTC) Received: by mail-ea0-f182.google.com with SMTP id a14so3125905eaa.13 for ; Sun, 25 Nov 2012 02:08:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=s+UxEwz1lsh5qWrlWvAgZ1bFusqpEyPFGeyFWG7i3Rs=; b=fK7aEvDY02jnfAqaDauv5MMYNEcA2fOhAxZ/rh4NbyKv20NrYrATWYgagcouEdP3Wg YgpV/ULduhxY+RuJ5Brlu7ZUxf4g1yzbDL7nhot+BVmdjvzFdPpw1Bc89rJe6yXoh1Vt pb0gZoe5GdGF9OeZtqvaoLAbHhCaHbqGT8fHRzS/JxnNXlNEAAiSODZQTkD19Vh0qvww 7l28BRN+ddom0KG0pZLhc9/Vx7Dp1+YSSVClFSc/YOAY7ONUgwEsHgaQOUY0tHvMU6TY I2U6PKfi3A8DJeBB5gkBWeYCr/RAdhdcXajsLFiozHKbeCcoqUHo22b+CJtqV0Zgsm+8 1UYQ== Received: by 10.14.215.194 with SMTP id e42mr65911eep.32.1353838107391; Sun, 25 Nov 2012 02:08:27 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPS id q2sm26247895eem.13.2012.11.25.02.08.26 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 02:08:26 -0800 (PST) Sender: Baptiste Daroussin Date: Sun, 25 Nov 2012 11:08:25 +0100 From: Baptiste Daroussin To: Wesley Shields Subject: Re: svn commit: r307565 - head/net/silc-client Message-ID: <20121125100824.GB33816@ithaqua.etoilebsd.net> References: <201211191622.qAJGMZps097391@svn.freebsd.org> <20121120111700.GI71195@ithaqua.etoilebsd.net> <20121125032245.GB10784@atarininja.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TRYliJ5NKNqkz5bu" Content-Disposition: inline In-Reply-To: <20121125032245.GB10784@atarininja.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2012 10:08:29 -0000 --TRYliJ5NKNqkz5bu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 24, 2012 at 10:22:45PM -0500, Wesley Shields wrote: > On Tue, Nov 20, 2012 at 12:17:00PM +0100, Baptiste Daroussin wrote: > > I know I already told you the following, but I think it is worth saying= it > > loudly for other people who don't know yet about OPTIONS_DEFINE_${arch} > >=20 > > regards, > > Bapt > >=20 > > On Mon, Nov 19, 2012 at 04:22:35PM +0000, Wesley Shields wrote: > > > Author: wxs > > > Date: Mon Nov 19 16:22:34 2012 > > > New Revision: 307565 > > > URL: http://svnweb.freebsd.org/changeset/ports/307565 > > >=20 > > ... > > > WANT_PERL=3D yes > > > =20 > > > -OPTIONS=3D PTHREADS "Enable pthreads support" off \ > > > - IPV6 "Enable IPv6 support" on \ > > > - ICONV "Enable international character support" on \ > > > - PERL "Enable perl support" on \ > > > - OPTIMIZED_ASM "Use assembler optimizations (i386 only)" on > > > +OPTIONS_DEFINE=3D PTHREADS IPV6 ICONV PERL OPTIMIZED_ASM > > > +PTHREADS_DESC=3D "Enable pthreads support" > > > +OPTIMIZED_ASM_DESC=3D "Use assembler optimizations (i386 only)" > > > +OPTIONS_DEFAULT=3D IPV6 ICONV PERL OPTIMIZED_ASM > >=20 > > OPTIONS_DEFINE=3D -PTHREADS IPV6 ICONV PERL > > OPTIONS_DEFINE_i386=3D OPTIMIZED_ASM > > OPTIMIZED_ASM_DESC=3D Use assembler optimizations > > ... > > > -.include > > > +.include > > > =20 > > > .if ${ARCH} !=3D "i386" > > > WITHOUT_OPTIMIZED_ASM=3D yes > > > .endif > >=20 > > The above is uneeded as OPTIMIZED_ASM will never get defined with the _= arch > > syntax above. >=20 > Fixed all of these. Thanks for catching it and pointing me to the proper > way to do it! >=20 > I do have one question. In r307732 I had to change ${PERL} to just > 'perl' in the PERL_ARCHNAME!=3D line. This was working prior to the switch > to the new options so I'm curious if I did something wrong or uncovered > a bug? >=20 > -- WXS This is because ${PERL} is set by USE_PERL5, which is included after bsd.port.options.mk and you need it at the moment you parse the Makefile be= cause of: PERL_ARCHNAME!=3D ${PERL} -V:archname 2>/dev/null || true so what you have to do is either: =2Einclude Some checking =2Einclude here is ${PERL} =2Einclude or directly =2Einclude Some checking Here is ${PERL} =2Einclude Of course I haven't test the above regards, Bapt --TRYliJ5NKNqkz5bu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCx7hgACgkQ8kTtMUmk6EzsXgCeLQlBjRqsQ/ChZPnY1eMUmNoe VhYAoKrDfsIHdqmioWI3UuPgjnkyjmz0 =6mP7 -----END PGP SIGNATURE----- --TRYliJ5NKNqkz5bu--