From owner-svn-src-all@FreeBSD.ORG Tue Apr 12 20:31:33 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 96B4F106564A; Tue, 12 Apr 2011 20:31:33 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 8602F8FC0C; Tue, 12 Apr 2011 20:31:33 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p3CKVXtd034883; Tue, 12 Apr 2011 20:31:33 GMT (envelope-from pjd@svn.freebsd.org) Received: (from pjd@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p3CKVX2q034881; Tue, 12 Apr 2011 20:31:33 GMT (envelope-from pjd@svn.freebsd.org) Message-Id: <201104122031.p3CKVX2q034881@svn.freebsd.org> From: Pawel Jakub Dawidek Date: Tue, 12 Apr 2011 20:31:33 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r220575 - head/cddl/contrib/opensolaris/lib/libzfs/common X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2011 20:31:33 -0000 Author: pjd Date: Tue Apr 12 20:31:33 2011 New Revision: 220575 URL: http://svn.freebsd.org/changeset/base/220575 Log: Fix 'zfs list ' handling. If the path was found, the 'ret' variable was uninitialized. PR: kern/155940 Submitted by: KOIE Hidetaka MFC after: 1 week Modified: head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c Modified: head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c ============================================================================== --- head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c Tue Apr 12 20:10:15 2011 (r220574) +++ head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c Tue Apr 12 20:31:33 2011 (r220575) @@ -734,12 +734,13 @@ zfs_path_to_zhandle(libzfs_handle_t *hdl { struct statfs sfs; - if (statfs(path, &sfs) != 0) { + ret = statfs(path, &sfs); + if (ret == 0) + statfs2mnttab(&sfs, &entry); + else { (void) fprintf(stderr, "%s: %s\n", path, strerror(errno)); - ret = -1; } - statfs2mnttab(&sfs, &entry); } #endif /* sun */ if (ret != 0) {