From nobody Fri May 1 21:08:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g6kDc0zJYz6cJ0j for ; Fri, 01 May 2026 21:09:04 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g6kDZ4D54z3nKq for ; Fri, 01 May 2026 21:09:02 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-42321c8b8f5so1933360fac.1 for ; Fri, 01 May 2026 14:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1777669736; x=1778274536; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NdJVb3zUt3Tz7U3/6W21HA9PwECZl6LwMa9okZWOqNU=; b=bm5Gp1IOFuCrV4uStnlxHjd90wLXBGq7JAMjnpP4l88r9955tRGZaRs2qcQugSGxjc QmOQsRDEe9MW6VUiJZaVnrm16JFTiu22dsuN+o71URqLx0cKKE3njaK0n1GExLTTjsUY tZk3HJHA92ksk1JDx9rG4R6PgsSxZ7vnELpt4jolYxVPuwxnho9ERU8WY6mzjsVLlLhl 1T0e5SVo72xoW9QwCAzd4i+jtoxTEWiCafw2iIiqsIWSCeKQmdlL9tQ1pmyBtUgiQySH wrb8LSm1woZMHMTvVAu3XCn9zTRcX1SQGo3YWsFDsF+iS7JCu0D2tTgWxxaUVUcQC3so Tfhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777669736; x=1778274536; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NdJVb3zUt3Tz7U3/6W21HA9PwECZl6LwMa9okZWOqNU=; b=Eixll/x2aHqBQMccgtkTi3yDpN/yZ8wWzph/zD0/X0OVEGmvNq1qeDsMTt6aZhT4Ot rT20KMr8hf4RC99ZGGkYPc0JUmvYQOCbVF40eGB2trpFrhya8rRZDdGic5ZBkrms90S+ 7Cw/MHGuuB5aLuwF0rDAZnBwnKQExL8vVmEbWoyuCreNHFusm+V8B8+TwpHuJS/3zRQb 7vofq2xdx03Pin6XWYDuhiRdINu1QXpOFiJOZuwufMk3/M/PUEKFfEKP7/1e0XtC0pfw 76xrIL9Z2kcYEmJULYxR0QJQTS+7JFVicbRHpGk5uMY4iDs3UeLFPaXb9zeMvoMedsiv KMmA== X-Forwarded-Encrypted: i=1; AFNElJ+sIeaRh+H0pOKU9D+SsL+7/Vii9dXhJZr7ylx/L3eJ5d4KN9etRKRwWPW5zwNy5pARTab0ClpYcNxvcEfzDPw2DHhl@freebsd.org X-Gm-Message-State: AOJu0YxhWl/NUY6QIOiwbRKR1Hr6KBgM/Q/GJIgNLkjO/BWX+Pr76LwC /wjfiEt0su/bNzyu0JQUl28Fvl8MKpoi1Gz+Feeau68kcB147YtDJZHfLJgUsqQM+fk= X-Gm-Gg: AeBDieu0+P7WNUrXBKO/crxZEIpRfuN5IdMDe04fbfbrqZEtJqTe8FU+rOX2k+nU/0S qjyDaQEvpkgVkT+EkH9O+EMUD60kLsbDKWW02pkvV6LxVj4C1nkzl611WGXW3PcYQIPLOsKyg7l q1qZoooGHfzWZ9QFPbdL5sk6tvIp7tR7wn35hrsEK6ZyXwgv/mO0r1NXYuRRJjoCkKP3L7Mm6KR QHdf+kjAk4AiTy+szqYHZuuG8lrfTkOTi6rsxhHq83OVChsA1RYEZKuodINrSamGknekDdIcktb 6swFJHpcLds8ANzbXvsF5ieU3OyAZM2NDmOiioxpmF/KRw+Nfwk7AqCqjKtbZuS0xQGEn6x6t7a 7QjIqEEGrDmRWn5pRyb0UeUhpe2Atw5xvXKXBDHwANu3lUynK9ZOiFsq73/pORv8gvjsQJrxup0 vvALTCos8qtpdAOUD7tW51xSryzM4UyA== X-Received: by 2002:a05:6870:ac98:b0:42c:ecb:233a with SMTP id 586e51a60fabf-43438b7a265mr3806538fac.18.1777669736082; Fri, 01 May 2026 14:08:56 -0700 (PDT) Received: from mutt-hbsd ([97.112.164.127]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43454dd93fcsm3701777fac.18.2026.05.01.14.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 14:08:55 -0700 (PDT) Date: Fri, 1 May 2026 21:08:54 +0000 From: Shawn Webb To: Mark Johnston Cc: Oliver Pinter , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Mariusz Zaborski Subject: Re: git: f5ea3dce2cbe - main - libnv: switch fd_wait() from select(2) to poll(2) Message-ID: X-Operating-System: FreeBSD mutt-hbsd 15.0-STABLE-HBSD FreeBSD 15.0-STABLE-HBSD HARDENEDBSD amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <69f219fc.3d583.73783562@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h5a4sgkpwbgrab7i" Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:15169, ipnet:2001:4860:4864::/48, country:US] X-Rspamd-Queue-Id: 4g6kDZ4D54z3nKq X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --h5a4sgkpwbgrab7i Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: f5ea3dce2cbe - main - libnv: switch fd_wait() from select(2) to poll(2) MIME-Version: 1.0 On Fri, May 01, 2026 at 04:11:48PM -0400, Mark Johnston wrote: > On Fri, May 01, 2026 at 09:11:17AM +0100, Oliver Pinter wrote: > > On Wednesday, April 29, 2026, Mark Johnston wrote: > >=20 > > > The branch main has been updated by markj: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D > > > f5ea3dce2cbe1ee2068c5e5c11bb066f5789685b > > > > > > commit f5ea3dce2cbe1ee2068c5e5c11bb066f5789685b > > > Author: Mariusz Zaborski > > > AuthorDate: 2026-04-28 14:35:10 +0000 > > > Commit: Mark Johnston > > > CommitDate: 2026-04-29 14:39:28 +0000 > > > > > > libnv: switch fd_wait() from select(2) to poll(2) > > > > > > The previous implementation used FD_SET() on a stack-allocated fd= _set, > > > which is an out-of-bounds write whenever the socket fd is >=3D FD= _SETSIZE > > > (1024). > >=20 > >=20 > > This problem seems like a more generic problem, after looking into > > sys/select.h > >=20 > > What about adding a check for the FD_SET about the variable is on the s= tack > > or not? And enforce the FD_SETSIZE limit almost the same way as it is > > already done with fortify source. >=20 > FORTIFY_SOURCE would automatically detect the addition of out-of-bounds > fds, so as a mitigation I would like to propose enabling it by default. As a small data point, HardenedBSD has set _FORTIFY_SOURCE=3D2 for both src and ports (integrated back when Kyle Evans committed the original work). Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --h5a4sgkpwbgrab7i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmn1FlwACgkQ/y5nonf4 4fqyjxAAgzgS8Qk013YaaafrQK3okguZRg3QmMBK3s4xnT4jVPPjFCYRRoQkukul 8LB0VebiFggu1efr4zgBQ/wppu42/yrP9E+2OFVlp+Z1MZIQHGPfgddbqcahq7TR MVvR9IOCA/1PxfS0CkEFZ3F7ptLOjNw5MyBy28W/Aoh6LGB/VH2lVB17Q11QHiSG NmiU++QAz7ax+B+zdeGS1QqHRIDJjoPwZwJmKt95Pny8Nugh9p4VVC99NUsxqi+i 5tpwRDHEviqZTTL91EkcPnp/8G0cewfvTWB9vDX+F2NpuZBtX8sWu80WSIvGmgQQ TFYxWc9eRkH9kFFhzyMGK4VV3spoUp411JNFgYRim468FZ5n/I6cUbTkxdNpXYos vLxaOhH/21q8giNIN7Vbcj/iTU4M/o+gWoDy7pRuY83DTq/pPll9kSVAZYxPmO2P 9ZbJaH9kfkzSzPu46QyQurEKqBwnA5vIwcxNwxf0DjiHbr/h2OEiJxUg7rx0Kmqr m29VgWqUsaJb2JKE9V8Vj7QLtWT6jJ1pOvrHH32S7VLJki/9yAQT4cs6FWK8b8H/ wj6ATD+IqVaHPjt+VItjgyYtthESjfwLZX2zIY3jj+byX6pUaOtY9F6DEZ3tEyjd 5gE7JYvULwhY8yfqzOx/6PUilWzSOH5AQ6j6TMY9Ju3Oo22+ZQQ= =oNaO -----END PGP SIGNATURE----- --h5a4sgkpwbgrab7i--