From owner-cvs-src@FreeBSD.ORG Mon Jan 31 23:39:05 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B4B316A4CE for ; Mon, 31 Jan 2005 23:39:05 +0000 (GMT) Received: from mail26.sea5.speakeasy.net (mail26.sea5.speakeasy.net [69.17.117.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC6C143D60 for ; Mon, 31 Jan 2005 23:39:04 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 10813 invoked from network); 31 Jan 2005 23:39:04 -0000 Received: from server.baldwin.cx ([216.27.160.63]) (envelope-sender )AES256-SHA encrypted SMTP for ; 31 Jan 2005 23:39:03 -0000 Received: from [10.50.40.202] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j0VNN2tn033233; Mon, 31 Jan 2005 18:23:04 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Maxim Sobolev Date: Mon, 31 Jan 2005 18:14:24 -0500 User-Agent: KMail/1.6.2 References: <200501252128.j0PLSSHE081956@repoman.freebsd.org> <200501311429.31197.jhb@FreeBSD.org> <41FE9CC7.4050305@portaone.com> In-Reply-To: <41FE9CC7.4050305@portaone.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200501311814.24008.jhb@FreeBSD.org> X-Spam-Status: No, score=-102.8 required=4.2 tests=ALL_TRUSTED, USER_IN_WHITELIST autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_misc.c src/sys/kern kern_time.c src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2005 23:39:06 -0000 On Monday 31 January 2005 04:01 pm, Maxim Sobolev wrote: > John Baldwin wrote: > > On Tuesday 25 January 2005 04:28 pm, Maxim Sobolev wrote: > >>sobomax 2005-01-25 21:28:28 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/compat/linux linux_misc.c > >> sys/kern kern_time.c > >> sys/sys systm.h > >> Log: > >> Split out kernel side of {get,set}itimer(2) into two parts: the first > >>that pops data from the userland and pushes results back and the second > >>which does actual processing. Use the latter to eliminate stackgap in the > >>linux wrappers of those syscalls. > >> > >> MFC after: 2 weeks > > > > Hmm, I already implemented kern_[sg]etitimer() locally and fixed all the > > ABIs, not just Linux to use them. I haven't had time to test the patches > > though. Would you be interested in them? > > I would be happy to, but I don't have any platforms other than i386 > (which is why I have not touched other arches). Therefore I am probably > a wrong person to do the testing. Is your approach different/better than > mine? I'd be happy to do the merge if so. I've already merged. It's mostly the same except I put the logic to fall back to kern_getitimer() when there is no new itimerval in kern_setitimer() rather than duplicating that in all the ABIs. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org