Date: Thu, 12 Mar 2009 20:59:05 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Guido van Rooij <guido@gvr.org> Cc: freebsd-fs@freebsd.org Subject: Re: RFC: geli+gmirror problem + solution Message-ID: <20090312195904.GA1786@garage.freebsd.pl> In-Reply-To: <20090311215518.GA25410@gvr.gvr.org> References: <20090311215518.GA25410@gvr.gvr.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 11, 2009 at 10:55:18PM +0100, Guido van Rooij wrote: > We have a setup where we have two disks in a gmirror with GELI on top > of it. We boot from it (using a small unencrypted USB stick). > We this have the G_ELI_FLAG_BOOT set. >=20 > Anyway, when rebooting, geli does not detach and this the gmirror is > never destroyed resulting in a rebuild each time. >=20 > I just commited a fix for this (set the G_ELI_FLAG_WO_DETACH in g_eli_tas= te(). > However, this seems to break zfs as zfs might actually close the geli dev= ice > and later opening it (but it is then no longer there). >=20 > We must therefor make this configurable. >=20 > I thus propose to be able to set the G_ELI_FLAG_WO_DETACH in the geli- > metadata, just like the G_ELI_FLAG_BOOT flag. This would mean an > extra option to geli init, say the -d flag. >=20 > Any objections? I'd suggest not to do it. Maybe you could implement detaching on reboot for geli providers? You can find example of how to do this in three last functions in sys/geom/mirror/g_mirror.c. Could you send me patches to review before committing? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFJuWmIForvXbEpPzQRAt1hAJ9UW8NOv7XmqOYkEq+MSUxKE1npaQCfTvzA DpmexskXV1aX4s6W2EG5IDI= =HFd3 -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090312195904.GA1786>