From owner-freebsd-current@FreeBSD.ORG Tue Jun 14 20:25:53 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BA1D1065670; Tue, 14 Jun 2011 20:25:53 +0000 (UTC) (envelope-from rickvanderzwet@gmail.com) Received: from mail-yi0-f54.google.com (mail-yi0-f54.google.com [209.85.218.54]) by mx1.freebsd.org (Postfix) with ESMTP id 224EE8FC14; Tue, 14 Jun 2011 20:25:52 +0000 (UTC) Received: by yic13 with SMTP id 13so2049766yic.13 for ; Tue, 14 Jun 2011 13:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=lIzk3JE15yktIpFE4fYLYHhqtlAUuth5+6HaBAi2EKY=; b=tcgKH3GTT2XcN6f/cddXxrOQdfbvLO6xv82k7JUaE84vu+B0Sve1jEOZE99NYx2O3h 2xzFPMX0QL3KRpJ7ZkcnYcLCfdBjMLGOaQQ4WLlTEdS0XKFpkVHP5sOcXJR0nwb/ruR7 ccaeqr/2AMIXsBArbjf53Q/ViGkaT1oJhcfOA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=AqFtNxOJoUltYY8SkDhNIy/nT5SfL0nfO0lecZri/ZVy0Pj4Y62DvM9Un0GeNMXGOc oKSL6A+0jEbDQc8Y0m0EHWD8eJtJVz491GL77Q995Rv2d1HNL19H1MbL8w+i3Vvu91B+ 6+Bm4QE/WcIRX8Tu0WCU0Suud/QmZu+Nv1MVg= MIME-Version: 1.0 Received: by 10.236.105.143 with SMTP id k15mr10014962yhg.161.1308083152229; Tue, 14 Jun 2011 13:25:52 -0700 (PDT) Sender: rickvanderzwet@gmail.com Received: by 10.236.76.41 with HTTP; Tue, 14 Jun 2011 13:25:52 -0700 (PDT) In-Reply-To: <4DF76176.7030207@FreeBSD.org> References: <4DF76176.7030207@FreeBSD.org> Date: Tue, 14 Jun 2011 22:25:52 +0200 X-Google-Sender-Auth: SMwZ_kUDiugj5_Qum9WRUmLmNmc Message-ID: From: Rick van der Zwet To: Alexander Motin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD-Current Subject: Re: ATA_PERIODIC_POLL on ATA_I82801HBM_S1 causes lockups X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2011 20:25:53 -0000 On 14 June 2011 15:26, Alexander Motin wrote: > Rick van der Zwet wrote: >> The ICH8M found in the MacBookPro4,1 has an known issue [1] which >> locks up when enabling the periodic poll using sidpr (introduced a >> ``little'' while ago in r214016), making it impossible to boot. >> >> Attached patch disables the polling and thus fixes the issue. >> >> Br. /Rick >> [1] http://www.spinics.net/lists/linux-ide/msg23487.html > > Thank you for reminder, but your patch is not exactly right. Could you > test this one: > > Index: ata-intel.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- ata-intel.c (revision 223019) > +++ ata-intel.c (working copy) > @@ -288,7 +288,9 @@ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ATA_OUTL(ctlr->r_res2, 0x0= C, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ATA_INL(ctlr->r_re= s2, 0x0C) | 0xf); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} > - =A0 =A0 =A0 } else { > + =A0 =A0 =A0 /* Skip BAR(5) on ICH8M Apples, system locks up on access. = */ > + =A0 =A0 =A0 } else if (ctlr->chip->chipid !=3D ATA_I82801HBM_S1 || > + =A0 =A0 =A0 =A0 =A0 pci_get_subvendor(dev) !=3D 0x106b) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ctlr->r_type2 =3D SYS_RES_IOPORT; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ctlr->r_rid2 =3D PCIR_BAR(5); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ctlr->r_res2 =3D bus_alloc_resource_any(de= v, ctlr->r_type2, Works like a charm. Br. /Rick --=20 http://rickvanderzwet.nl