From owner-freebsd-net Mon Mar 19 10: 0:24 2001 Delivered-To: freebsd-net@freebsd.org Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.157]) by hub.freebsd.org (Postfix) with ESMTP id C311937B718 for ; Mon, 19 Mar 2001 10:00:21 -0800 (PST) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.11.1/8.11.1) id f2JHx2m79301; Mon, 19 Mar 2001 20:59:02 +0300 (MSK) (envelope-from yar) Date: Mon, 19 Mar 2001 20:59:02 +0300 From: Yar Tikhiy To: Luigi Rizzo Cc: freebsd-net@FreeBSD.ORG Subject: Re: A few nasty bugs in the networking code Message-ID: <20010319205902.M43447@comp.chem.msu.su> References: <20010319203104.L43447@comp.chem.msu.su> <200103191732.SAA85848@info.iet.unipi.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200103191732.SAA85848@info.iet.unipi.it>; from luigi@info.iet.unipi.it on Mon, Mar 19, 2001 at 06:32:44PM +0100 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Mon, Mar 19, 2001 at 06:32:44PM +0100, Luigi Rizzo wrote: > > > We are heading to a new release, but the bugs are still there. > > > > Could a commiter do me a favor and take a look at the following reports: > > which are about ??? you know we are better at parsing text strings than > numbers... Sorry, I'll explain what the bugs are. > > kern/22176 if_delmulti() (net/if.c) does not notify a corresponding interface driver when a _link-layer_ multicast group is being left. Hence hardware multicast filters won't get reloaded etc. Of course, one may rarely need link-layer mcast groups (but I did). Nevertheless, it's a bug and must be fixed. > > kern/22177 There is a mtod() without a prior m_pullup() in netinet/if_ether.c. The system might be likely to crash sometimes... > > kern/22178 The vlan driver don't update byte/packet counters that it should to. > > kern/22179 The vlan driver mishandles the interface flags. That may lead to Bad Things like crashes sometimes... > > kern/22181 The vlan driver's author got a wrong idea about the struct sockaddr_dl contents when writing the code. It's also a good idea to check the return value of malloc()... SY, Yar To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message