From owner-svn-ports-all@freebsd.org  Sat Jun  9 22:04:35 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C92B5100D775;
 Sat,  9 Jun 2018 22:04:35 +0000 (UTC) (envelope-from steve@mouf.net)
Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client CN "mouf.net", Issuer "mouf.net" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 6A91879F6A;
 Sat,  9 Jun 2018 22:04:35 +0000 (UTC) (envelope-from steve@mouf.net)
Received: from [10.200.21.66] ([137.122.64.159]) (authenticated bits=0)
 by mouf.net (8.14.9/8.14.9) with ESMTP id w59M4OFX035853
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
 Sat, 9 Jun 2018 22:04:29 GMT (envelope-from steve@mouf.net)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mouf.net; s=mail;
 t=1528581872; bh=HKN7E6kbnB1roRP6E6X3WOtlUkjfTsyWS4Z8CqRraZs=;
 h=Subject:To:References:From:Date:In-Reply-To;
 b=Ef6Y1Y1wQeXDJXhxEKXwfZhgrvX0jCWx8G+ncCysv4nlv7Zna7uimB+Wt8pLlu48X
 ClgDO9Xck8RpW83GUsMoXyDmmc9UbvmuAIBMOay7CQs2L10otxVs9/JvHgdzStfD6h
 jjfTtEnDs9+VRK+6Jq4owyghzstdFIb1y8RqxY4I=
Subject: Re: svn commit: r472097 - in head/databases/mongodb36: . files
To: Eugene Grosbein <eugen@grosbein.net>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, dev@dudu.ro
References: <201806092133.w59LXtVZ035695@repo.freebsd.org>
 <5B1C4B96.9060907@grosbein.net>
From: Steve Wills <steve@mouf.net>
Openpgp: preference=signencrypt
Message-ID: <75fe1030-630c-9ce5-7f9e-a07123db6902@mouf.net>
Date: Sat, 9 Jun 2018 18:04:19 -0400
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <5B1C4B96.9060907@grosbein.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mouf.net [199.48.129.64]); Sat, 09 Jun 2018 22:04:30 +0000 (UTC)
X-Spam-Status: No, score=1.5 required=4.5 tests=HELO_MISC_IP,RDNS_NONE
 autolearn=no autolearn_force=no version=3.4.1
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net
X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net
X-Virus-Status: Clean
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Jun 2018 22:04:36 -0000

Fair enough, perhaps even a patch to add a comment in the file would be
useful. Note too that it can be overridden.

Steve

On 06/09/18 17:50, Eugene Grosbein wrote:
> 10.06.2018 4:33, Steve Wills wrote:
> 
>> Author: swills
>> Date: Sat Jun  9 21:33:55 2018
>> New Revision: 472097
>> URL: https://svnweb.freebsd.org/changeset/ports/472097
>>
>> Log:
>>   databases/mongodb36: upgrade to 3.6.5
>>   
>>   PR:		228806
>>   Submitted by:	dev@dudu.ro (maintainer)
> 
> [skip[
> 
>> Modified: head/databases/mongodb36/files/mongod.in
>> ==============================================================================
>> --- head/databases/mongodb36/files/mongod.in	Sat Jun  9 21:30:38 2018	(r472096)
>> +++ head/databases/mongodb36/files/mongod.in	Sat Jun  9 21:33:55 2018	(r472097)
>> @@ -30,7 +30,7 @@ load_rc_config $name
>>  : ${mongod_enable="NO"}
>>  %%LEGACY_LIMITS%%: ${mongod_limits="NO"}
>>  : ${mongod_dbpath="/var/db/mongodb"}
>> -: ${mongod_flags="--logpath ${mongod_dbpath}/mongod.log --logappend"}
>> +: ${mongod_flags="--logpath ${mongod_dbpath}/mongod.log --logappend --setParameter=disabledSecureAllocatorDomains=\*"}
>>  : ${mongod_user="mongodb"}
>>  : ${mongod_group="mongodb"}
>>  : ${mongod_config="%%PREFIX%%/etc/mongodb.conf"}
> 
> The change seems suspictious to uneducated eye. Perhaps, some commentary in the commit log
> would be useful, like: mongodb36 now requires disabling "SecureAllocator" that uses mlock()
> to be useful for restricted users, or else it crashes with SIGABRT in fassert()
> complaining "Failed to mlock: Operation not permitted".
> 
>  
> 
>