From owner-svn-src-head@FreeBSD.ORG Mon Nov 17 23:17:27 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 311BAD76; Mon, 17 Nov 2014 23:17:27 +0000 (UTC) Received: from mail-wg0-x232.google.com (mail-wg0-x232.google.com [IPv6:2a00:1450:400c:c00::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B5784767; Mon, 17 Nov 2014 23:17:26 +0000 (UTC) Received: by mail-wg0-f50.google.com with SMTP id k14so8088058wgh.37 for ; Mon, 17 Nov 2014 15:17:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=jVfaQfChIkHOdR+W823H2eMQJ7Q4YT65d0boOaOkbLM=; b=KIuvJ4j11ZGLCvwSaVHx2Estrgr1LlYGC4bf9g8xgscxmnvrtyiKpU2v9PzmEKkcz1 vLSyI5+DNvCDdQBXxTxIgGtaX70X3iamjF0HTZG7c13e1gHRT/bohdbOrIDUKdIDTl5B /oJL7f0WfohIsPTXDk8Iu7M1N9K9vC6Jm6TGAo66ZDHe03YgKHQEcMvrexlNUbuh1UTe 3M9DUqrzUuKfE2aD1r54yhUvo3nVGianDA3qkjr1T1vIDj/0AmvHcuDCVLUMwRWmJUru RfSy6w0xXNNMHCeKJD3bJl0bna4GiAGg/5dXucrlQ/txdhlUBpbdeD25azvoVQ/IHe69 6jDA== MIME-Version: 1.0 X-Received: by 10.180.188.102 with SMTP id fz6mr25847172wic.59.1416266245234; Mon, 17 Nov 2014 15:17:25 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.106.136 with HTTP; Mon, 17 Nov 2014 15:17:25 -0800 (PST) In-Reply-To: <2245618.H2SPKlpWdS@ralph.baldwin.cx> References: <201411172025.sAHKPLMl055666@svn.freebsd.org> <2245618.H2SPKlpWdS@ralph.baldwin.cx> Date: Mon, 17 Nov 2014 15:17:25 -0800 X-Google-Sender-Auth: 0MRDlcMsQ_FtEP6s2CGIZ7O3mAM Message-ID: Subject: Re: svn commit: r274635 - head/sys/dev/pci From: Adrian Chadd To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Dmitry Chagin X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2014 23:17:27 -0000 On 17 November 2014 14:45, John Baldwin wrote: > On Monday, November 17, 2014 08:25:21 PM Dmitry Chagin wrote: >> Author: dchagin >> Date: Mon Nov 17 20:25:21 2014 >> New Revision: 274635 >> URL: https://svnweb.freebsd.org/changeset/base/274635 >> >> Log: >> Use the correct device as the power_for_sleep() method >> always pass request up to parent bridge. >> >> Reviewed by: jhb >> MFC after: 1 week >> xMFC: r274386,r274397 > > Hmm, I had misread this diff as being another instance of what Adrian had > found. I think this is actually not correct. The parent of a pci device > ('dev' here) is a pciX device. pciX devices do not implement the > PCIB_POWER_FOR_SLEEP method from pcib_if.m, so this probably just broke > Adrian's Asus laptop as now it will always use D3 again and ignore _SxD. > > You said that this change fixed your laptop, yes? Did it work before Adrian's > change in r274386 and break afterwards? Hm, it doesn't cascade up to the parent of dev if it's called? -adrian