From nobody Mon Apr 14 13:47:15 2025 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZbpW74Shgz5sqsG for ; Mon, 14 Apr 2025 13:47:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZbpW71lXJz3HrR for ; Mon, 14 Apr 2025 13:47:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744638435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HcVlwOU6VQMMLpMkzE9JJj1hDL/dqfbb82xb/LQtyGs=; b=E6+Yw9VWn+etnOGxUhj8SWgchRrSQQa7RpY0+2PVAGUo0jzbl30Q0a/JB3swLN2NEZpD3c ZPMcCLUHDmin4dqncb3fMCKyw9R7Wx1ilXXugHXYbSFkwiKLBG1g6R+XWI8O+SQfVfVMVb y5PQRoAG9kNK2CbDwZoHUaLxDC0QACjWjKudnxkdppIK92LqbHVke8m451zqGEQbQO2Jlr LMSW5+jDRN2wRdBZNBVE7q3cCrGoNfLUW2NvtOWJnS5RPu1pqC0pcAKIWY6Z4USzE4Y2wr xkrsOZsiOPkORSV+r6QaiFrvbwQXzU98XhW5Swq0jWxaczUwQmECAxsuhz0LPA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744638435; a=rsa-sha256; cv=none; b=I1fHBn2dH+kx1FSN6GFvramk7Y2oXVywyEmqq/IVkdkdy6su2KOo6M1cecaNqLYqtVsdDu YkSUxl0bPdGb87YJDEbb+dTaSLwwTGvQdT64wxC8aVM65Jw5TbVYfTWpXQeRn0o4VUBJNx 0HH49MgJJEs2YO+OgOpq94pg1mtL9u1Gl/5zixDx782ErJIi+B/UStjggXvvUVsYit4nnU fhe/VJ8yCopUP603Of++9xTOkuRgpsT62Ux6wPuvmhePMDcXxqnfkr63NmVVLWLG2nVtTg 1NO9LKnOTq3QSCMdzF0rEX9wPBoqTZgMIWcDQLvAdu1lho85m0KE9pnmYgHuvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744638435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HcVlwOU6VQMMLpMkzE9JJj1hDL/dqfbb82xb/LQtyGs=; b=Hqb6J3i3LQtomRQtDOVx1y7a5JirE21fI3NCfoSCzb4XzjvxPa49Y79Zvx3VKj4epCumsh Nzh6OItz2XgGqVM+ILty04qaSJLb4zpqFD+zjlZYbpHooB+860fL0VovJ66/PXdl4H7DHS 6QctgHn81LuNlhox95uNpHSiqK5fFsam1sWPO2WcJhK7AUzESbkFWu5Iz5kR/LW51bzBMI oLeEnRzVUhy/JKB7Z/E0qkicRVxueEJuZw7NZAZxn6WTmmLkxVIvt1w7jWNoCE5Kxi8Oep gLTPpL++VMEW62rI4ubGPGUM854pPWAaQj0s/84z8ErCd0KxQpBjqIUdqm7/FA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZbpW719R1zrHm for ; Mon, 14 Apr 2025 13:47:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 53EDlFr8006763 for ; Mon, 14 Apr 2025 13:47:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 53EDlFOK006762 for bugs@FreeBSD.org; Mon, 14 Apr 2025 13:47:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 285993] nvme device breakage in 14.2 STABLE n270867-25df691800f0 Date: Mon, 14 Apr 2025 13:47:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.2-STABLE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: freebsd-bugzilla@umpquanet.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D285993 --- Comment #10 from Jim Long --- (In reply to Jim Long from comment #9) No joy. The Toshiba SSD only has Windows/GUI firmware update tools. Relative to n271055, I have reduced the necessary patch for my hardware to = boot to be: 06:41:08 /usr/src# git diff diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index 6f5d6ae74add..ea1de2b98e9f 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -1524,16 +1524,10 @@ nvme_ctrlr_destruct(struct nvme_controller *ctrlr, device_t dev) goto noadminq; /* - * Check whether it is a hot unplug or a clean driver detach. If device - * is not there any more, skip any shutdown commands. Some hotplug - * bridges will return zeros instead of ff's when the device is - * departing, so ask the bridge if the device is gone. Some systems= can - * remove the drive w/o the bridge knowing its gone (they don't rea= lly - * do hotplug), so failsafe with detecting all ff's (impossible with - * this hardware) as the device being gone. + * Check whether it is a hot unplug or a clean driver detach. + * If device is not there any more, skip any shutdown commands. */ - gone =3D bus_child_present(dev) =3D=3D 0 || - (nvme_mmio_read_4(ctrlr, csts) =3D=3D NVME_GONE); + gone =3D (nvme_mmio_read_4(ctrlr, csts) =3D=3D NVME_GONE); if (gone) nvme_ctrlr_fail(ctrlr); else I'm trying to look into why my hardware results in returning (bus_child_present(dev) =3D=3D 0) but I'm not finding where the *definition= * of BUS_CHILD_PRESENT is. Plenty of references, but no definition, to my novice eyes. Clues appreciated, as always. --=20 You are receiving this mail because: You are the assignee for the bug.=