From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 12 17:40:28 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6CAD16A4CF for ; Sun, 12 Sep 2004 17:40:27 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id BFEFF43D58 for ; Sun, 12 Sep 2004 17:40:27 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8CHeRSO009168 for ; Sun, 12 Sep 2004 17:40:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8CHeR8h009167; Sun, 12 Sep 2004 17:40:27 GMT (envelope-from gnats) Resent-Date: Sun, 12 Sep 2004 17:40:27 GMT Resent-Message-Id: <200409121740.i8CHeR8h009167@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2393716A4CE for ; Sun, 12 Sep 2004 17:36:50 +0000 (GMT) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id 01C1043D49 for ; Sun, 12 Sep 2004 17:36:49 +0000 (GMT) (envelope-from dan@obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8CHald6010922 for ; Sun, 12 Sep 2004 19:36:47 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8CHafpO010921 for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 19:36:41 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <200409121736.i8CHafpO010921@kulesh.obluda.cz> Date: Sun, 12 Sep 2004 19:36:41 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/71670: [PATCH] usr.sbin/asf may use uninialised variables X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 17:40:28 -0000 >Number: 71670 >Category: bin >Synopsis: [PATCH] usr.sbin/asf may use uninialised variables >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 17:40:27 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 i386 usr.sbin/asf/asf.c,v 1.6 2003/11/04 06:38:37 green >Description: usr.sbin/asf/asf.c:245: warning: 'textaddr' might be used uninitialized in this function usr.sbin/asf/asf.c:246: warning: 'dataaddr' might be used uninitialized in this function usr.sbin/asf/asf.c:247: warning: 'bssaddr' might be used uninitialized in this function Those warnings are real bugs. When output of objdump doesn't contain information about .text or .data or .bss section then corresponding variable remain uninitialized, but used. >How-To-Repeat: N/A >Fix: *** usr.sbin/asf/asf.c.ORIG Fri Nov 14 03:53:00 2003 --- usr.sbin/asf/asf.c Sun Sep 12 17:33:13 2004 *************** *** 242,250 **** if ((!(strstr(buf, "kernel"))) && buf[0] != 'I') { quad_t base; ! quad_t textaddr; ! quad_t dataaddr; ! quad_t bssaddr; tokens = tokenize(buf, token, MAXTOKEN); base = strtoll(token[2], NULL, 16); --- 242,250 ---- if ((!(strstr(buf, "kernel"))) && buf[0] != 'I') { quad_t base; ! quad_t textaddr = 0; ! quad_t dataaddr = 0; ! quad_t bssaddr = 0; tokens = tokenize(buf, token, MAXTOKEN); base = strtoll(token[2], NULL, 16); >Release-Note: >Audit-Trail: >Unformatted: