From owner-svn-src-head@FreeBSD.ORG Mon Jan 16 06:15:14 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C01D91065675; Mon, 16 Jan 2012 06:15:14 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id AF0128FC25; Mon, 16 Jan 2012 06:15:14 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q0G6FEfk019545; Mon, 16 Jan 2012 06:15:14 GMT (envelope-from davidxu@svn.freebsd.org) Received: (from davidxu@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q0G6FE9r019542; Mon, 16 Jan 2012 06:15:14 GMT (envelope-from davidxu@svn.freebsd.org) Message-Id: <201201160615.q0G6FE9r019542@svn.freebsd.org> From: David Xu Date: Mon, 16 Jan 2012 06:15:14 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r230201 - head/lib/libc/gen X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2012 06:15:14 -0000 Author: davidxu Date: Mon Jan 16 06:15:14 2012 New Revision: 230201 URL: http://svn.freebsd.org/changeset/base/230201 Log: Insert read memory barriers. Modified: head/lib/libc/gen/sem.c head/lib/libc/gen/sem_new.c Modified: head/lib/libc/gen/sem.c ============================================================================== --- head/lib/libc/gen/sem.c Mon Jan 16 06:00:44 2012 (r230200) +++ head/lib/libc/gen/sem.c Mon Jan 16 06:15:14 2012 (r230201) @@ -434,7 +434,7 @@ _libc_sem_post_compat(sem_t *sem) return ksem_post((*sem)->semid); atomic_add_rel_int(&(*sem)->count, 1); - + rmb(); if ((*sem)->nwaiters) return _umtx_wake(&(*sem)->count); return (0); Modified: head/lib/libc/gen/sem_new.c ============================================================================== --- head/lib/libc/gen/sem_new.c Mon Jan 16 06:00:44 2012 (r230200) +++ head/lib/libc/gen/sem_new.c Mon Jan 16 06:15:14 2012 (r230201) @@ -332,6 +332,7 @@ _sem_getvalue(sem_t * __restrict sem, in static __inline int usem_wake(struct _usem *sem) { + rmb(); if (!sem->_has_waiters) return (0); return _umtx_op(sem, UMTX_OP_SEM_WAKE, 0, NULL, NULL);