Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Sep 2006 22:37:49 -0600
From:      Scott Long <scottl@samsco.org>
To:        Jan Mikkelsen <janm@transactionware.com>
Cc:        freebsd-stable@freebsd.org
Subject:   Re: Patch: sym(4) "VTOBUS FAILED" panics on amd64, amd64/89550
Message-ID:  <451A001D.3040005@samsco.org>
In-Reply-To: <003001c6e119$b7d59e20$c801a8c0@transactionware.com>
References:  <003001c6e119$b7d59e20$c801a8c0@transactionware.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Jan Mikkelsen wrote:

> Attached is a simpler patch, after some feedback from Stefan over general
> niceness.
> 
> It removes the amd64 special case by splitting the target member (an array
> of struct sym_tcb) of sym_hcb out into a separately allocated structure.
> This way there is never a need to allocate anything bigger than a page and
> the whole problem goes away with minimal change, less wasted memory and
> fewer outright hacks.
> 
> I did spend some time looking at ripping out the custom allocator entirely,
> and got as far as it building and one of the cache tests failing.  I don't
> think I'm going to spend the time to track down why;  if anyone wants to
> pick it up then let me know.
> 
> Regards,
> 
> Jan Mikkelsen

Looks very reasonable.  Stefen, did you want to handle getting this into
CVS, or would you like me to do it?

Scott




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?451A001D.3040005>