Date: Mon, 14 Mar 2011 12:38:22 -0700 From: Garrett Cooper <gcooper@FreeBSD.org> To: Matthew D Fleming <mdf@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217586 - in head: sbin/sysctl share/man/man9 sys/cam/scsi sys/dev/cxgb sys/dev/wi sys/net sys/sys Message-ID: <AANLkTin6YY8-jQkgsNg3OPEh0CfQKV42ag%2BLoEOB8Mg8@mail.gmail.com> In-Reply-To: <201101191704.p0JH47ZS082977@svn.freebsd.org> References: <201101191704.p0JH47ZS082977@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 19, 2011 at 9:04 AM, Matthew D Fleming <mdf@freebsd.org> wrote: > Author: mdf > Date: Wed Jan 19 17:04:07 2011 > New Revision: 217586 > URL: http://svn.freebsd.org/changeset/base/217586 > > Log: > =A0sysctl(8) should use the CTLTYPE to determine the type of data when > =A0reading. =A0(This was already done for writing to a sysctl). =A0This > =A0requires all SYSCTL setups to specify a type. =A0Most of them are now > =A0checked at compile-time. > > =A0Remove SYSCTL_*X* sysctl additions as the print being in hex should be > =A0controlled by the -x flag to sysctl(8). I appreciate the work, but this really should have been followed up by a __FreeBSD_version__ bump, as this unfortunately broke some ports like emulators/*qemu*. I just filed a PR for it as I noticed it when doing portmaster -af for the recent X.org upgrade. FWIW, this can be properly tested with: __FreeBSD_version__ < 900031; kib bumped the version a week after this commit. Thanks, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTin6YY8-jQkgsNg3OPEh0CfQKV42ag%2BLoEOB8Mg8>