Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 31 Jan 2020 18:09:28 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r357339 - projects/clang1000-import/usr.sbin/bsnmpd/modules/snmp_pf
Message-ID:  <202001311809.00VI9S7O003080@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dim
Date: Fri Jan 31 18:09:27 2020
New Revision: 357339
URL: https://svnweb.freebsd.org/changeset/base/357339

Log:
  Fix the following -Werror warning from clang 10.0.0 in bsnmpd:
  
  usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c:1661:4: error: misleading indentation; statement is not part of the previous 'else' [-Werror,-Wmisleading-indentation]
                          return (-1);
                          ^
  usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c:1658:5: note: previous statement is here
                  } else
                    ^
  
  The intent was to group the return statement with the previous syslog()
  call.
  
  MFC after:	3 days

Modified:
  projects/clang1000-import/usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c

Modified: projects/clang1000-import/usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c
==============================================================================
--- projects/clang1000-import/usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c	Fri Jan 31 18:04:04 2020	(r357338)
+++ projects/clang1000-import/usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c	Fri Jan 31 18:09:27 2020	(r357339)
@@ -1655,10 +1655,11 @@ altq_is_enabled(int pfdev)
 			syslog(LOG_INFO, "No ALTQ support in kernel\n"
 			    "ALTQ related functions disabled\n");
 			return (0);
-		} else
+		} else {
 			syslog(LOG_ERR, "DIOCGETALTQS returned an error: %s",
 			    strerror(errno));
 			return (-1);
+		}
 	}
 	return (1);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202001311809.00VI9S7O003080>