Date: Sat, 22 Dec 2001 11:27:11 +0900 From: Jun Kuriyama <kuriyama@imgsrc.co.jp> To: Current <FreeBSD-current@FreeBSD.org> Subject: Forward: if_fxp.c typo? Message-ID: <7md718f0qo.wl@waterblue.imgsrc.co.jp> References: <86y9kzqjlr.wl@keiichi01.osaka.iij.ad.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
--Multipart_Sat_Dec_22_11:27:11_2001-2 Content-Type: text/plain; charset=US-ASCII Hmm, -current has same problem. It should fix in -current... --Multipart_Sat_Dec_22_11:27:11_2001-2 Content-Type: multipart/digest; boundary="Multipart_Sat_Dec_22_11:27:11_2001-1" Content-Transfer-Encoding: 7bit --Multipart_Sat_Dec_22_11:27:11_2001-1 Content-Type: message/rfc822 From: Keiichi SHIMA / =?ISO-2022-JP?B?GyRCRWc3RDBsGyhC?= <keiichi@iij.ad.jp> Subject: if_fxp.c typo? Date: Thu, 22 Nov 2001 08:47:09 +0000 (UTC) Sender: owner-freebsd-stable@FreeBSD.ORG Message-ID: <86y9kzqjlr.wl@keiichi01.osaka.iij.ad.jp> Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII To: freebsd-stable@FreeBSD.ORG Delivered-To: freebsd-stable@freebsd.org X-Original-Date: Thu, 22 Nov 2001 17:45:52 +0900 User-Agent: Wanderlust/2.6.0 (Twist And Shout) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-1?Q?Unebigory=F2mae?=) APEL/10.2 MULE XEmacs/21.1 (patch 14) (Cuyahoga Valley) (i386--freebsd) List-ID: <freebsd-stable.FreeBSD.ORG> List-Archive: <http://docs.freebsd.org/mail/>; (Web Archive) List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions) List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable> List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable> X-Loop: FreeBSD.ORG Precedence: bulk Hi all, fxp_stop() of the latest fxp driver do SOFTWARE_RESET when called. Shouldn't this be SELECTIVE_RESET? As I'm not familiar with fxp, would someone check and commit it to the repositry? The current code clears all the hardware mc filters already set, as a result, the box can't receive any multicast packets (this is a serious problem especially when using ipv6). --- Keiichi SHIMA IIJ Research Laboratory <keiichi@iij.ad.jp> KAME Project <keiichi@kame.net> --- orig/if_fxp.c Thu Nov 8 18:30:10 2001 +++ if_fxp.c Thu Nov 22 17:22:38 2001 @@ -1429,7 +1429,7 @@ * Issue software reset, which also unloads the microcode. */ sc->flags &= ~FXP_FLAG_UCODE; - CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SOFTWARE_RESET); + CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SELECTIVE_RESET); DELAY(50); /* To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message --Multipart_Sat_Dec_22_11:27:11_2001-1 Content-Type: message/rfc822 From: Jun Kuriyama <kuriyama@imgsrc.co.jp> Subject: Re: if_fxp.c typo? Date: Wed, 19 Dec 2001 23:32:50 +0000 (UTC) Sender: owner-freebsd-stable@FreeBSD.ORG Message-ID: <7mn10ebxbp.wl@waterblue.imgsrc.co.jp> References: <86y9kzqjlr.wl@keiichi01.osaka.iij.ad.jp> Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=ISO-2022-JP To: freebsd-stable@FreeBSD.ORG Delivered-To: freebsd-stable@freebsd.org X-Original-Date: Thu, 20 Dec 2001 08:32:26 +0900 In-Reply-To: <86y9kzqjlr.wl@keiichi01.osaka.iij.ad.jp> User-Agent: Wanderlust/2.6.0 (Twist And Shout) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.1 (i386--freebsd) MULE/5.0 (=?ISO-2022-JP?B?GyRCOC1MWhsoQg==?=) List-ID: <freebsd-stable.FreeBSD.ORG> List-Archive: <http://docs.freebsd.org/mail/>; (Web Archive) List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions) List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable> List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable> X-Loop: FreeBSD.ORG Precedence: bulk I noticed this fixes my problem, but I don't know this patch is logically correct or not. I think we should commit this before 4.5-RELEASE if this is correct way. Can someone comment this? At Thu, 22 Nov 2001 08:47:09 +0000 (UTC), Keiichi SHIMA / 島慶一 wrote: > fxp_stop() of the latest fxp driver do SOFTWARE_RESET when called. > Shouldn't this be SELECTIVE_RESET? > > As I'm not familiar with fxp, would someone check and commit it to the > repositry? The current code clears all the hardware mc filters > already set, as a result, the box can't receive any multicast packets > (this is a serious problem especially when using ipv6). ... > --- orig/if_fxp.c Thu Nov 8 18:30:10 2001 > +++ if_fxp.c Thu Nov 22 17:22:38 2001 > @@ -1429,7 +1429,7 @@ > * Issue software reset, which also unloads the microcode. > */ > sc->flags &= ~FXP_FLAG_UCODE; > - CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SOFTWARE_RESET); > + CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SELECTIVE_RESET); > DELAY(50); > > /* -- Jun Kuriyama <kuriyama@imgsrc.co.jp> // IMG SRC, Inc. <kuriyama@FreeBSD.org> // FreeBSD Project To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message --Multipart_Sat_Dec_22_11:27:11_2001-1-- --Multipart_Sat_Dec_22_11:27:11_2001-2-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7md718f0qo.wl>