From owner-svn-ports-head@FreeBSD.ORG Mon Aug 12 13:22:10 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 2929796; Mon, 12 Aug 2013 13:22:10 +0000 (UTC) Date: Mon, 12 Aug 2013 13:22:10 +0000 From: Alexey Dokuchaev To: Alex Dupre Subject: Re: svn commit: r324628 - in head/ports-mgmt/portconf: . files Message-ID: <20130812132210.GA24822@FreeBSD.org> References: <201308121305.r7CD58rT096600@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201308121305.r7CD58rT096600@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2013 13:22:10 -0000 On Mon, Aug 12, 2013 at 01:05:08PM +0000, Alex Dupre wrote: > New Revision: 324628 > URL: http://svnweb.freebsd.org/changeset/ports/324628 > > Add dash (-) and plus (+) symbols to allowed characters in variable names: > > Dash symbols are required when using OptionsNG and $UNIQUENAME_SET/UNSET. > e.g. apache22-event-mpm_SET=... > > Plus symbols can be used to extend existing variables. e.g. OPTIONS_SET+=... I'm a bit worried if this change could potentially allow OPTIONS knobs themselves have -/+ chars in their names. This would be unfortunate, as there are plans for future OptionsNG enhancements that are making use of these chars for special purposes. ./danfe