From owner-freebsd-stable@freebsd.org Thu Sep 5 18:26:08 2019 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7AF72EFBE8 for ; Thu, 5 Sep 2019 18:26:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46PTf73jYmz4Crh for ; Thu, 5 Sep 2019 18:26:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x733.google.com with SMTP id f10so3084535qkg.7 for ; Thu, 05 Sep 2019 11:26:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WuwBvSCbq7XNjYPa9aRahDcnlXfZRjq1lqFA+f0jAB8=; b=XetTcqYkTSdRhHRts5owiXmGaBEOzHV/KhUycDSfLWHpaNrFtVIz1Ts9W21/9ubaS9 uxrokOK58FnbKkq4Wa/T4jRKBagCwPFIzoi1Gr/SmNqRuwFckCyiFPTjNrE5YTV07DZE TO8Vw3VU2Zl7h8PveU7fXfUtYULpxwakgNOCQmPcRf7xwf55Bh+gHgNWCpdvmierUtbF QZDUJaGP0CSjmHaT1NoZfDW1V0HYtk4xu3uLYZgNJiEESWdPTHkIBJG2YL9nvNQrgLsF +pmTBNAAUH6MJOtdzxkFvmqsgRTd2KX98xMcJUSe8glXl/F5GaZpaviO1OUbGxbEWZHg fStw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WuwBvSCbq7XNjYPa9aRahDcnlXfZRjq1lqFA+f0jAB8=; b=paf4nVe0TMrT3M68E1QbYK2p7c8J1YmWnMW83z9ska3shX9U1vVA5wz4EL+AfnWBOb qmOhecyMkB3QQ3oC7GrU6DKrCkFGWogAk6QvF4s8atZfTFKkDbyJSrflGxdgL/tpqoen l+pPs90OOU75JpUqD/ejh+xwzqwMNj5P9Pk/nPS9ky6rmrsN6UIX8yPTK2QbS8D+GLPU tmFjfCA7Z1fxCwqDwJ9DlQdUTU9njVprooZjn+sRbIINR5mjSM62k3YYJDaOQ+DdT4UC sHxwdx2jtayV6he4lKvVQB0W9Qen+ZXn9Vi9VeWW4pDGmyE0yiuv+UPCUle159rwxec/ zIqA== X-Gm-Message-State: APjAAAWgSSRT5pyLxaivpKzjPEJ3HDlDvZFHHWtf6Sl0/dhcuqsHcHXh 9f0rXqbUpwVbgNZG6Pezq6d+0CfAl5K7tFAVVPO1ZQ== X-Google-Smtp-Source: APXvYqwW3HNrPJDBRxMDx9janaV6JXIdzojBEPD605Kj4TMpZL+J2fSyugJL5N7BuuIwtHaA0BFFhnJZ/IV8LEXmPw8= X-Received: by 2002:a37:30f:: with SMTP id 15mr4063076qkd.240.1567707965834; Thu, 05 Sep 2019 11:26:05 -0700 (PDT) MIME-Version: 1.0 References: <2c82b556-59e8-cee1-19ab-7b16666ee58a@gmx.com> In-Reply-To: <2c82b556-59e8-cee1-19ab-7b16666ee58a@gmx.com> From: Warner Losh Date: Thu, 5 Sep 2019 12:25:54 -0600 Message-ID: Subject: Re: devd rule wierd output To: Nikos Vassiliadis Cc: FreeBSD-STABLE Mailing List X-Rspamd-Queue-Id: 46PTf73jYmz4Crh X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=XetTcqYk; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::733) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-5.88 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[3.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-1.00)[-0.997,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[gmx.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.88)[ip: (-9.32), ipnet: 2607:f8b0::/32(-2.76), asn: 15169(-2.27), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2019 18:26:08 -0000 On Thu, Sep 5, 2019 at 12:08 PM Nikos Vassiliadis wrote: > Hi, > > I have this in my devd rules: > > notify 10 { > > match "system" "ZFS"; > > match "type" "misc.fs.zfs.scrub_start"; > > action "touch /var/run/scrub_$pool_name; logger -t ZFS 'zpool > $pool_name started scrubbing'"; > > }; > > While this is working OK on FreeBSD-10, on FreeBSD-12 I noticed that > $pool_name is different. FreeBSD-10: > Sep 5 20:35:56 clio ZFS: zpool clio started scrubbing > FreeBSD-12: > Sep 5 20:47:35 aurora ZFS[1302]: zpool $aurora-os started scrubbing > > While it assigns the value, it weirdly includes a dollar sign > at the front. > > Thoughts? > Should I open a PR? > Please file a PR. Ideally, if you could connect to /var/run/devd.pipe before starting the scrub and including the output on 10 and 12, that would be great. Warner