From owner-freebsd-bugs@freebsd.org  Fri Jan 20 04:59:43 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4370BCB9982
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Fri, 20 Jan 2017 04:59:43 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2D62B1D28
 for <freebsd-bugs@FreeBSD.org>; Fri, 20 Jan 2017 04:59:43 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v0K4xg3D045392
 for <freebsd-bugs@FreeBSD.org>; Fri, 20 Jan 2017 04:59:43 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 165471] bsdgrep(1) hang/very slow with mmap
Date: Fri, 20 Jan 2017 04:59:42 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: bsdports@kyle-evans.net
X-Bugzilla-Status: In Progress
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc attachments.created
Message-ID: <bug-165471-8-T7UJDvNQ0R@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-165471-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-165471-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jan 2017 04:59:43 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D165471

Kyle Evans <bsdports@kyle-evans.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bsdports@kyle-evans.net

--- Comment #4 from Kyle Evans <bsdports@kyle-evans.net> ---
Created attachment 179123
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179123&action=
=3Dedit
Proposed patch to address issues with bsdgrep --mmap

As pointed out by Mateusz, bsdgrep --mmap does not handle EOF properly when=
 the
file does not end with a newline. I still don't get quite the performance in
/usr/local/share that the original reporter does, but bsdgrep is now actual=
ly
responsive in /usr/local/share.

I'm attaching a patch that reworks bits of the loop in grep_fgetln to return
the rest of the line and ensure that we still advance the buffer by the len=
gth
of the rest of the line. This improves both the original scenario as well as
Mateusz's more trivial test case.

--=20
You are receiving this mail because:
You are the assignee for the bug.=