From nobody Mon Feb 27 15:04:41 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PQP160MWwz3vDRT for ; Mon, 27 Feb 2023 15:04:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PQP154FQJz3M4R for ; Mon, 27 Feb 2023 15:04:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677510281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rM1Tk2YSdG6/BavaLX0AtKIf1M2NBBRpWWlvS2QHO+8=; b=lWV329AaAOfxCO3bsUO2dq8qbokgoLv0JJPlojhKiIZoYMfnm+4tdH4auhJ5beEfD6kIhX yIoBMr2kgxKIV5zEW2a2ez1vfze7jslcisvWTJXxX2qnFgV9CIlBkOOEh5u1jI5/Leqj5p /Fj28Vaslk4memQP347JzecGcxwEwLfm1gK7CSrNse2A7i8UHY3JRZZEy75nTKRw+OIT+S Lrm/rJSqDLTPVtDVCetmDOJ3fbxiwPmTk4h8NWrZq9C0weLH3hmCF77x34+cE4Yrm8ud6f t5ieiLkLvNurwbJMQzS5roK5QO/7x7C4IQdzv6kS/aCmgkTu9raw6SVb1/s0wA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677510281; a=rsa-sha256; cv=none; b=cRvHhH7YkjjyeeUeEBLjzTAf1IwyU3S3S8dJvHacge+aO++CQju83mAjb34/HxIJK2t2F6 g/tfxZauQvFJrVUBO/6TjRX3n0LRD7sew6GtUoC+5dvihNXRGutvzr+M4mvVbdvYFKwa97 C+0gh9r6/JMicF4ShwpYUdwBNxXsyBJ9eZKzAVk/U9UUdkfSrHil0AaxrhK5/CsUAQkMT/ yF1pqN30GOMWri+ZQr/Op5Md+KgTb6B6xO0KZaZ8nH0vjTbJuGp8B40mg7MOWxe2Wi5K3Y g8GxNomFB/JW1e336URbiE+m6TdSr2yx7p4h869GyDWCwZA4TJolZaajxQ90jg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PQP15350XzW6k for ; Mon, 27 Feb 2023 15:04:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 31RF4fa0066277 for ; Mon, 27 Feb 2023 15:04:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 31RF4fe8066276 for ports-bugs@FreeBSD.org; Mon, 27 Feb 2023 15:04:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 261398] [exp-run] check use of IP_BINDMULTI and IP_RSS_LISTEN_BUCKET Date: Mon, 27 Feb 2023 15:04:41 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: glebius@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261398 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D3aff4ccdd714105db340d68f1a2aea2f4= 6e99122 commit 3aff4ccdd714105db340d68f1a2aea2f46e99122 Author: Mark Johnston AuthorDate: 2023-02-27 14:52:28 +0000 Commit: Mark Johnston CommitDate: 2023-02-27 15:03:11 +0000 netinet: Remove IP(V6)_BINDMULTI This option was added in commit 0a100a6f1ee5 but was never completed. In particular, there is no logic to map flowids to different listening sockets, so it accomplishes basically the same thing as SO_REUSEPORT. Meanwhile, we've since added SO_REUSEPORT_LB, which at least tries to balance among listening sockets using a hash of the 4-tuple and some optional NUMA policy. The option was never documented or completed, and an exp-run revealed nothing using it in the ports tree. Moreover, it complicates the already very complicated in_pcbbind_setup(), and the checking in in_pcbbind_check_bindmulti() is insufficient. So, let's remove it. PR: 261398 (exp-run) Reviewed by: glebius Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D38574 sys/netinet/in.h | 1 - sys/netinet/in_pcb.c | 47 ++-----------------------------------------= ---- sys/netinet/in_pcb.h | 4 ---- sys/netinet/ip_output.c | 8 -------- sys/netinet6/in6.h | 1 - sys/netinet6/in6_pcb.c | 18 ++---------------- sys/netinet6/ip6_output.c | 9 --------- 7 files changed, 4 insertions(+), 84 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=