Date: Mon, 27 Feb 2023 15:04:41 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 261398] [exp-run] check use of IP_BINDMULTI and IP_RSS_LISTEN_BUCKET Message-ID: <bug-261398-7788-lmJ78KumRI@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-261398-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-261398-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261398 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D3aff4ccdd714105db340d68f1a2aea2f4= 6e99122 commit 3aff4ccdd714105db340d68f1a2aea2f46e99122 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2023-02-27 14:52:28 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2023-02-27 15:03:11 +0000 netinet: Remove IP(V6)_BINDMULTI This option was added in commit 0a100a6f1ee5 but was never completed. In particular, there is no logic to map flowids to different listening sockets, so it accomplishes basically the same thing as SO_REUSEPORT. Meanwhile, we've since added SO_REUSEPORT_LB, which at least tries to balance among listening sockets using a hash of the 4-tuple and some optional NUMA policy. The option was never documented or completed, and an exp-run revealed nothing using it in the ports tree. Moreover, it complicates the already very complicated in_pcbbind_setup(), and the checking in in_pcbbind_check_bindmulti() is insufficient. So, let's remove it. PR: 261398 (exp-run) Reviewed by: glebius Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D38574 sys/netinet/in.h | 1 - sys/netinet/in_pcb.c | 47 ++-----------------------------------------= ---- sys/netinet/in_pcb.h | 4 ---- sys/netinet/ip_output.c | 8 -------- sys/netinet6/in6.h | 1 - sys/netinet6/in6_pcb.c | 18 ++---------------- sys/netinet6/ip6_output.c | 9 --------- 7 files changed, 4 insertions(+), 84 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-261398-7788-lmJ78KumRI>