From owner-freebsd-current@FreeBSD.ORG Tue Apr 1 04:02:19 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5C75C4B3; Tue, 1 Apr 2014 04:02:19 +0000 (UTC) Received: from mail-ob0-x22b.google.com (mail-ob0-x22b.google.com [IPv6:2607:f8b0:4003:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 180AAE83; Tue, 1 Apr 2014 04:02:18 +0000 (UTC) Received: by mail-ob0-f171.google.com with SMTP id wn1so10369393obc.2 for ; Mon, 31 Mar 2014 21:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=8H2znuxFY+jfxJdMmHGXTchZoqqjxYaMl7rbi9gm6rM=; b=SyH1oh6wGz99kXMp3M78OSmhpvj8tED1P6Woa8kRgUy12r6mqlhA76awJz56+RWiY5 ipP2R1F+e6qP2j9gMRRMo4ucZxo0Ifyauey6aM+zlEpvDKNzj1V8bokzVLmrxf5ohLDd zZICvnE66kA7Kd42wZtlPG7Y57LnVQxk6MhnLw62DJFwuEoQj2QMZuZYKZz6OR9oCK9O Q4sSbzpjO2HQczAvX/1qXMxffRobnJ2Vmjky6X8CiAM7x/kzXyZKWRwo2nuG2D3xU75/ 4kWdDfpMpugyScigrfD7VeoJCcXvCet9102WNo/gytfDY374SQKGYY3K+bu+EphXJ6xI gZsA== MIME-Version: 1.0 X-Received: by 10.60.77.35 with SMTP id p3mr6498236oew.46.1396324938252; Mon, 31 Mar 2014 21:02:18 -0700 (PDT) Received: by 10.182.130.71 with HTTP; Mon, 31 Mar 2014 21:02:18 -0700 (PDT) In-Reply-To: <533A2285.2030705@FreeBSD.org> References: <201403261122.43541.jhb@freebsd.org> <5333F020.8000200@FreeBSD.org> <201403271221.29864.jhb@freebsd.org> <533A2285.2030705@FreeBSD.org> Date: Tue, 1 Apr 2014 00:02:18 -0400 Message-ID: Subject: Re: Re: UDP Lite support From: Joe Nosay To: Kevin Lo , freebsd-current Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Apr 2014 04:02:19 -0000 On Mon, Mar 31, 2014 at 10:20 PM, Kevin Lo wrote: > On 2014/03/28 00:21, John Baldwin wrote: > >> On Thursday, March 27, 2014 5:32:16 am Kevin Lo wrote: >> >>> Are you interested in working on these and report back? >>>>>> >>>>> The revised patch is available at: >>>>> http://people.freebsd.org/~kevlo/udplite.diff >>>>> >>>> Thank you for your suggestions. >>> >>> A few suggestions: >>>> >>>> - I would just drop the INP lock and return EOPNOTSUPP directly rather >>>> than using goto's to 'bad_setoptname' and 'bad_getoptname' so the >>>> UDP-lite options are self-contained. >>>> >>> Fixed. >>> >> Thanks. >> >> - I'm not a super big fan of all the udp_common_* macros only because >>>> I think it obfuscates things. At the very least, please move these >>>> things out of the header and into udp_usrreq.c so they are closer >>>> to the implementation. I would even suggest making them inline >>>> functions instead of macros. >>>> >>> Okay, I removed two udp_common_* macros. I also renamed >>> udp_common_init() >>> to udp_udplite_init() and moved it into udp_usrreq.c. Using a macro here >>> to follow the style used in SCTP (sctp_os_bsd.h). >>> >>> Here's a third version of the udp-lite patch: >>> http://people.freebsd.org/~kevlo/udplite.diff >>> >> Ok, I would say that udp_common_init() is actually a better name if you >> keep >> the macro (which I think is fine) rather than udp_udplite_init() as the >> macro >> is not specific to UDP Lite. However, thanks for moving the macros out >> of the >> header. >> > > Thank you John. glebius@ suggests we don't need to have two absolutely > equal uma zones since most systems don't run UDP-Lite. > If practice shows that a differentiation at zone level between UDP and > UDP-Lite PCBs is important, then it could be done later. > > Following up with a fourth version of the udp-lite patch. > http://people.freebsd.org/~kevlo/udplite.diff > > On top of the previous versions, this: > - removes a uma zone for udp-lite > - udp_common_ctlinput() belongs under #ifdef INET > - removes sysctl nodes for udp-lite. > - bumps version and adds my copyright. > > Kevin > > > Do I patch over the current src- which was already patched with version 3- or do I just start new?