From owner-svn-src-all@freebsd.org Mon Jun 24 22:23:47 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01E2315DB0E1 for ; Mon, 24 Jun 2019 22:23:47 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8DD7C8BB1A; Mon, 24 Jun 2019 22:23:46 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd33.google.com with SMTP id u19so248489ior.9; Mon, 24 Jun 2019 15:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Mk3PPn/mQ44iK6OMfDFPSOGw/NsiV7I/wJJ7hoAZFNI=; b=RFGh4Idtc2wcFnCmZAvttZ0at+Qoo98B+evtVC5zfm7O92TFyLnjgARLT5os5Fm7wo oSglGzkFgjnL22Kwn3vs6vjUvX22xYLsnhXfcZrZUDR/CEVK+RFQZZCP63J/ZiLoyEZU tzCqQfjWgzxVJbGpnRCJNbCUv4jRO/1VxZCEQLBT9t+1mAdFuR7fqy90bQihV2o4wMNs yW+m6Ix4BABJfVESbJnDqDn7Iga9In+8WqICIxEb/hEHSnA5YJGHPvmoqo6m4KREvTms Rn06XswomlukGnc3dsTySkGDx5i7JywZwp12i6uQP6Z/MuZjDLmRaYZpGNoTJl9lSYXo 7ctg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Mk3PPn/mQ44iK6OMfDFPSOGw/NsiV7I/wJJ7hoAZFNI=; b=QDwSUmHg/w7wRRKuddBeIVEOnMhMvQ7DVhqI7vuMcspNzcf7gxYIDDqbnO1FM9UmVU Y155yeSLbj/bGyppPPx8+Qlj7fRIlXAi1vJfghK9ICIfvz0znhEvKDkOVMNZg0ll2Y6o GjkdD/iteTRDNa18fW6Sjn1SoksvN36RGfynG7OnVlbl1KmoXDIsB/Fh8ly9ykvTBxTO 8pgGbQr8Pbn36qzn2DsPANi7mOc0UErCGzPVp46k2dzVa/d5mYRsKuNzkdxpqKcgO4bQ eiXSufgWOuaAW8W0G4zN4zHnKZtmoGLd+inqGlihYkhePqHLs9Hp8Q0t8tBujSbjFBd3 LEjA== X-Gm-Message-State: APjAAAVtLGflvzIBSd/5SNFY4z/i3XGuwEjkmwnV+vvsuJGhXSScD7fy btRLsyz9uMS4ulRAa2ixKjlmZK4EOL0= X-Google-Smtp-Source: APXvYqxhN6zNg5DlX6b/BufPyTvByYS0uSijiJ5B3c1muhIOR+XJdV03nBikFG/YKLeHG1/5OOBF8Q== X-Received: by 2002:a5d:80c3:: with SMTP id h3mr36625355ior.167.1561415025291; Mon, 24 Jun 2019 15:23:45 -0700 (PDT) Received: from raichu (toroon0560w-lp140-05-70-29-85-38.dsl.bell.ca. [70.29.85.38]) by smtp.gmail.com with ESMTPSA id p63sm31989235iof.45.2019.06.24.15.23.43 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jun 2019 15:23:43 -0700 (PDT) Sender: Mark Johnston Date: Mon, 24 Jun 2019 18:23:41 -0400 From: Mark Johnston To: Gleb Smirnoff Cc: Gordon Tetlow , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r349198 - releng/12.0/sys/net Message-ID: <20190624222341.GB37940@raichu> References: <201906191641.x5JGfIsY027804@repo.freebsd.org> <20190624212540.GQ67242@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190624212540.GQ67242@FreeBSD.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Rspamd-Queue-Id: 8DD7C8BB1A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.970,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jun 2019 22:23:47 -0000 On Mon, Jun 24, 2019 at 02:25:40PM -0700, Gleb Smirnoff wrote: > Hi, > > On Wed, Jun 19, 2019 at 04:41:18PM +0000, Gordon Tetlow wrote: > G> Author: gordon > G> Date: Wed Jun 19 16:41:18 2019 > G> New Revision: 349198 > G> URL: https://svnweb.freebsd.org/changeset/base/349198 > G> > G> Log: > G> Fix incorrect locking in networking stack. > G> > G> Approved by: so > G> Security: FreeBSD-EN-19:11.net > > do I understand correct that problem isn't applicable to head, since > it was accidentially covered in r340413? Either fix for stable or > r340413 aren't a good looking code. I don't know about "accidentally," but yes. The problem was that r340413 could not easily be MFCed. See D17996 and D19764.