Date: Mon, 1 Oct 2007 08:26:01 GMT From: Jaap Boender <jaapb@kerguelen.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/116780: libtunepimp fails to compile Message-ID: <200710010826.l918Q1i9044185@www.freebsd.org> Resent-Message-ID: <200710010830.l918U1Sq055355@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 116780 >Category: ports >Synopsis: libtunepimp fails to compile >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Oct 01 08:30:01 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Jaap Boender >Release: 6.2-STABLE >Organization: >Environment: FreeBSD marion-dufresne.pps.jussieu.fr 6.2-STABLE FreeBSD 6.2-STABLE #6: Mon Aug 20 16:21:12 CEST 2007 root@marion-dufresne.pps.jussieu.fr:/usr/obj/usr/src/sys/MARION-DUFRESNE i386 >Description: The MP4Close function in my version of libmp4 (port mpeg4ip-libmp4v2-1.6) doesn't return a bool, but a void, which results in libtunepimp failing to compile. >How-To-Repeat: install audio/libtunepimp. >Fix: Adding the attached patch to the files directory of the port should solve the problem. Patch attached with submission follows: --- plugins/mp4/mp4.cpp.orig 2007-10-01 10:17:48.000000000 +0200 +++ plugins/mp4/mp4.cpp 2007-10-01 10:18:19.000000000 +0200 @@ -231,9 +231,7 @@ strcpy(mdata->fileFormat, fileName + strlen(fileName) - 3); - if (!MP4Close(mp4file)) - return 0; - + MP4Close(mp4file); return 1; } @@ -315,8 +313,7 @@ sprintf(temp, "%d", mdata->nonAlbum); MP4SetMetadataFreeForm(mp4file, "MusicBrainz Non-Album", (u_int8_t *)temp, strlen(temp) + 1); - if (!MP4Close(mp4file)) - return 0; + MP4Close(mp4file); #ifndef WIN32 if (!MP4Optimize(utf8ToEncoding(fileName, encoding).c_str())) >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710010826.l918Q1i9044185>