From owner-cvs-all@FreeBSD.ORG  Sun Nov 16 23:51:44 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3DADE16A4CE; Sun, 16 Nov 2003 23:51:44 -0800 (PST)
Received: from purple.the-7.net (purple.the-7.net [207.158.28.23])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3D92B43FE0; Sun, 16 Nov 2003 23:51:43 -0800 (PST)
	(envelope-from ab@astralblue.net)
Received: from astralblue.net (adsl-68-123-46-151.dsl.pltn13.pacbell.net
	[68.123.46.151])
	by purple.the-7.net (8.12.9p2/8.12.9) with ESMTP id hAH7rcKF032652;
	Sun, 16 Nov 2003 23:53:41 -0800 (PST)
	(envelope-from ab@astralblue.net)
Message-ID: <3FB87E09.40904@astralblue.net>
Date: Sun, 16 Nov 2003 23:51:37 -0800
From: =?UTF-8?B?IkV1Z2VuZSBNLiBLaW0g6rmA66+87ISxIg==?= <ab@astralblue.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: "Marc G. Fournier" <scrappy@hub.org>
References: <200311140823.hAE8NDAb005015@repoman.freebsd.org>
	<20031114105746.M497@ganymede.hub.org>
In-Reply-To: <20031114105746.M497@ganymede.hub.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham 
	version=2.60
X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on 
	purple.the-7.net
cc: cvs-src@freebsd.org
cc: David Schultz <das@freebsd.org>
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/fs/unionfs union_vnops.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Nov 2003 07:51:44 -0000

Marc G. Fournier wrote:

>Thank you, this reduces my 'list of known crash triggers' down to avoiding
>the use of sockets on unionfs mounted file systems :)
>
>
>On Fri, 14 Nov 2003, David Schultz wrote:
>
>
>>das         2003/11/14 00:23:13 PST
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/fs/unionfs       union_vnops.c
>>  Log:
>>  - A sanity check in unionfs verifies that lookups of '.' return the
>>    vnode of the parent.  However, this check should not be performed if
>>    the lookup failed.  This change should fix "union_lookup returning
>>    . not same as startdir" panics people were seeing.  The bug was
>>    introduced by an incomplete import of a NetBSD delta in rev 1.38.
>>  - Move the aforementioned check out from DIAGNOSTIC.  Performance
>>    is the least of our unionfs worries.
>>  - Minor reorganization.
>>
>>  PR:             53004
>>  MFC after:      1 week
>>
>>  Revision  Changes    Path
>>  1.103     +21 -27    src/sys/fs/unionfs/union_vnops.c
>>

Does this move unionfs into the `safe for general consumption' region, 
or is this particular problem just a tip of an iceberg?

Eugene