From owner-freebsd-hackers@FreeBSD.ORG  Sun Dec 23 09:40:46 2007
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4382D16A417
	for <freebsd-hackers@freebsd.org>; Sun, 23 Dec 2007 09:40:46 +0000 (UTC)
	(envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C74C13C43E
	for <freebsd-hackers@freebsd.org>; Sun, 23 Dec 2007 09:40:45 +0000 (UTC)
	(envelope-from des@des.no)
Received: from tim.des.no (localhost [127.0.0.1])
	by spam.des.no (Postfix) with ESMTP id 7ADB320C6;
	Sun, 23 Dec 2007 10:40:37 +0100 (CET)
X-Spam-Tests: AWL
X-Spam-Learn: disabled
X-Spam-Score: -0.1/3.0
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on tim.des.no
Received: from ds4.des.no (des.no [80.203.243.180])
	by smtp.des.no (Postfix) with ESMTP id 6239120B9;
	Sun, 23 Dec 2007 10:40:37 +0100 (CET)
Received: by ds4.des.no (Postfix, from userid 1001)
	id EC8CD84466; Sun, 23 Dec 2007 10:40:39 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Ed Maste <emaste@freebsd.org>
References: <20071219222621.GA79432@sandvine.com>
Date: Sun, 23 Dec 2007 10:40:39 +0100
In-Reply-To: <20071219222621.GA79432@sandvine.com> (Ed Maste's message of
	"Wed\, 19 Dec 2007 17\:26\:21 -0500")
Message-ID: <86ejddg354.fsf@ds4.des.no>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-hackers@freebsd.org
Subject: Re: config(8) patch for review for src dir handling
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Dec 2007 09:40:46 -0000

Ed Maste <emaste@freebsd.org> writes:
> Right now config(8) calls realpath("../..", ... to find the src path
> to write into the kernel Makefile.  I want to change this to use $PWD
> with the last two path components removed, assuming it's the same dir
> as ../.. .

I'm worried that your patch assumes that $PWD is present and correct,
for which there is no guarantee.  What happens if you use getcwd()
instead of getenv("PWD")?

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no