From owner-svn-ports-all@freebsd.org Fri Aug 31 22:10:38 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7919FCC2D2 for ; Fri, 31 Aug 2018 22:10:38 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6334287602 for ; Fri, 31 Aug 2018 22:10:38 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-yb1-xb32.google.com with SMTP id d34-v6so1412730yba.3 for ; Fri, 31 Aug 2018 15:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TCpVOFqYfDnG2jPDPYYNvxk6HusCoJnScnMlVilIiqA=; b=wd9MwxNL2VHidAtZ5JWya97C4mostXSicATHzf8fnFvSz0MkwrYAXap7YvcfS3faMH zftn/O82kJUCas6AC8Irr4UIMmv5xoTKcOfJwKA6U7Kz6UX20rb9LU68ss/IepGBdZnR 3pofijxzEUNFoBdBuKxBzFezKwhhF0+Qe3PTgCnSSPr6upoWPuFHjpWwwJFqLLNpGiYS 75Y2lxDdqGZcmEY1LLBoAuRIxTgcYDqdlgoILxRXgeB+gqFRiBFfuYShtzJs72vmEI14 sHPXtcbFMamDZwTJf02nvfwuUKstf9aklXYP0LQw7HNa8Z1C3ZvlD6sMBUeY++MwwgMO WUhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TCpVOFqYfDnG2jPDPYYNvxk6HusCoJnScnMlVilIiqA=; b=PdQvEkPuoJLPLRtrJVcKoUaiu1yAUdZ9DmrH8d4E4vgAk8wvVBSbPFJed+vaotq7Or Z5apGhzAcF9Slialu+m8WNQYpICh7mb9JNFsh6id1qZbwdafZBuOdtwRujXuZrMPHezp 2IhcY98I0lhqzJf1w2UlBrtci0yiQqDOPvEem/3OQYUKfOwND+okwSmM+E3w4CMisICp On842CQ+IIj8jPR+OTWpL/xmBP+2IUmNj9Eh4cU3RS0x2YNlH71V5Yf4pRHzlcivmsfB d1tIyNeUShMb+8ORTEI9Yo8uc+VegQrcgaGeDB2tX+RB9M+lcViLtPMQHGDjxFLezngc rp3w== X-Gm-Message-State: APzg51D7OeQ7BCGAkmL7fdWTBFvW/5kKDJpTQO9zvHWjSmp6zrxs3eUu +j1F4S34FZRyy9RWUG/huBBNam28oiZMWhwJw7RoMA== X-Google-Smtp-Source: ANB0Vdby9TdHdsOD5bDfNZBaTIepb/egQTrMhSaoD0YZmu8+CtUL4weXV05gmvn8YLpXgdgfDgH0hXVldKRPSZa0Q4M= X-Received: by 2002:a25:ef44:: with SMTP id w4-v6mr10214795ybm.417.1535753437552; Fri, 31 Aug 2018 15:10:37 -0700 (PDT) MIME-Version: 1.0 References: <201808312014.w7VKEwAC012418@repo.freebsd.org> <4lfa-19se-wny@FreeBSD.org> In-Reply-To: <4lfa-19se-wny@FreeBSD.org> From: Adam Weinberger Date: Fri, 31 Aug 2018 16:10:21 -0600 Message-ID: Subject: Re: svn commit: r478608 - head/devel/msgpack To: jbeich@freebsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 22:10:39 -0000 On Fri, Aug 31, 2018 at 3:55 PM Jan Beich wrote: > > Adam Weinberger writes: > > > On Fri, Aug 31, 2018 at 2:15 PM Jan Beich wrote: > > > >> > >> Author: jbeich > >> Date: Fri Aug 31 20:14:57 2018 > >> New Revision: 478608 > >> URL: https://svnweb.freebsd.org/changeset/ports/478608 > >> > >> Log: > >> devel/msgpack: restore TEST_TARGET after r470984 > >> > >> TEST_DEPENDS is pointless without do-test or TEST_TARGET. automake > >> required googletest only during "check" but cmake wants it upfront > >> during "test". So, move tests into a separate option. > > > > I don't get it. 130 ports out of 33,012 have TEST options. That's > > 0.3%. This sounds like your personal preference, not an "any > > maintainer would want this fixed" commit. OPTIONS are to let users > > customize the package, not to assist people who want to run their own > > regression tests. > > TEST option is only used when do-test cannot run with the default build. > Not all ports require such a configuration, many work simply by calling > "make test" from the port directory. Some ports only build tests when a > specific vendor target is called thus installing TEST_DEPENDS in time > for build system to pick them up. > > In msgpack there were 2 issues: > - "make test" didn't run tests at all, only installed googletest > - "make test" tried to run non-existing vendor "test" target because > googletest was installed too late, so cmake auto-disabled tests > > > The fact that poudriere doesn't automatically run tests is not > > justification to adding a non-standard OPTION. If you want to test it > > in poudriere, run testport -i and run ctest yourself. > > I disagree. Running tests were supported and done by default when the > package cluster (pointyhat at the time) used tinderbox, not poudriere. > After tinderbox was phased out regression-test and TEST_DEPENDS usage in > ports started to bitrot until amdmi3@ standardized the support outside > of tree building tools. Some of unsolved problems are integration into > poudriere, what to run by default (e.g., QAT slave) and fixing/flagging > broken tests. poudriere can be worked around via "pre-install: do-test" > but when a user enabled TEST option the intent is already clear. > > Not sure if you're joking about "testport -i" but many other packaging > systems run tests as part of automation. I applaud if you run it > manually on every update. Do you expect the next maintainer to continue > the tradition? > > > Please back this out. > > OK but TEST_DEPENDS will go away. If you don't bother to learn how > testing framework[1] works there's no benefit to keep the cruft aka the > remnants of the work you've trampled on via maintainer timeout. > > [1] see /usr/ports/CHANGES from 20150928 I don't disagree that running ctest manually is obtuse, but to me, the best solution to the problem is teaching poudriere to install TEST_DEPENDS and run 'make test'. The need for googletest to be brought in earlier was not on my radar because of the way that I test (I have a script that adds TEST_DEPENDS to BUILD_DEPENDS when testing in poudriere), and I see now why you put it in as an OPTION. Also, I'd like to thank you for the statement that I don't know how to use ports. It's a very helpful technique that made me really want to see it from your side. I also really appreciated the dig at me for committing after a maintainer timeout, when you chose to forego the PR process entirely. Thankfully, we know from experience how highly you rank your own opinions. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org