From owner-cvs-src@FreeBSD.ORG Wed Apr 25 21:54:24 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C271116A400 for ; Wed, 25 Apr 2007 21:54:24 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id A9E8613C489 for ; Wed, 25 Apr 2007 21:54:24 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 48753 invoked from network); 25 Apr 2007 21:53:57 -0000 Received: from 209-128-117-003.bayarea.net (HELO ?10.0.1.132?) (nate-mail@209.128.117.3) by root.org with ESMTPA; 25 Apr 2007 21:53:57 -0000 Message-ID: <462FCEB9.40406@root.org> Date: Wed, 25 Apr 2007 14:57:13 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.9 (X11/20070214) MIME-Version: 1.0 To: John Baldwin References: <20070425162233.8CCFC16A59E@hub.freebsd.org> <462F8672.7040200@root.org> <200704251356.35785.jhb@freebsd.org> In-Reply-To: <200704251356.35785.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2007 21:54:24 -0000 John Baldwin wrote: > On Wednesday 25 April 2007 12:48:50 pm Nate Lawson wrote: >> John Baldwin wrote: >>> jhb 2007-04-25 16:22:18 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/dev/acpica acpi.c >>> Log: >>> Use a tighter check to see if a resource allocation request is for a >>> specific request and thus should first try to be allocated from the >>> sys_resource pool. This avoids using the sys_resource pool for wildcard >>> requests that have bounded ranges coming from cbb(4) and Host-PCI > pcib(4) >>> drivers. >>> >>> Tested by: Andrea Bittau >>> Sleuthing by: Andrea Bittau as well >>> >>> Revision Changes Path >>> 1.235 +1 -1 src/sys/dev/acpica/acpi.c >>> >>> >>> Index: src/sys/dev/acpica/acpi.c >>> diff -u src/sys/dev/acpica/acpi.c:1.234 src/sys/dev/acpica/acpi.c:1.235 >>> --- src/sys/dev/acpica/acpi.c:1.234 Thu Mar 22 18:16:40 2007 >>> +++ src/sys/dev/acpica/acpi.c Wed Apr 25 16:22:18 2007 >>> @@ -1034,7 +1034,7 @@ >>> * the request from our system resource regions. If we can't, pass > the >>> * request up to the parent. >>> */ >>> - if (!(start == 0UL && end == ~0UL) && rm != NULL) >>> + if (start + count - 1 == end && rm != NULL) >>> res = rman_reserve_resource(rm, start, end, count, flags & ~RF_ACTIVE, >>> child); >>> if (res == NULL) { >> I think I'll test this to see if it helps my via 8235 ata survive boot. > > I wonder if in fact the algorithm shouldn't be changed to always try to alloc > the resource from the parent first, and only fall back to the sys_resource > rmans if that fails? In theory any resource requests that should be done via > sys_resource will fail the request in the parent, yes? > Yes, that should be ok but why not do local first and then push up tree if it fails? Semantically, a child of your bus requested the resource so most of the time you should be able to handle it. -- Nate