From owner-cvs-src@FreeBSD.ORG Wed May 9 16:38:24 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5DDD516A404 for ; Wed, 9 May 2007 16:38:24 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 1A05113C46C for ; Wed, 9 May 2007 16:38:24 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 16088 invoked from network); 9 May 2007 16:38:24 -0000 Received: from ppp-71-139-36-90.dsl.snfc21.pacbell.net (HELO ?10.0.5.16?) (nate-mail@71.139.36.90) by root.org with ESMTPA; 9 May 2007 16:38:24 -0000 Message-ID: <4641F9EF.6030902@root.org> Date: Wed, 09 May 2007 09:42:23 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.9 (X11/20070214) MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <200704222233.l3MMXUKH045452@repoman.freebsd.org> <86abwzio7t.fsf@dwp.des.no> <462CD3FD.6080300@root.org> <86tzurqp4d.fsf@dwp.des.no> <864pmn5lvd.fsf@dwp.des.no> <4640D8AA.40101@root.org> <86lkfzm2m7.fsf@dwp.des.no> <464172B0.4010507@root.org> <861whqckm3.fsf@dwp.des.no> In-Reply-To: <861whqckm3.fsf@dwp.des.no> X-Enigmail-Version: 0.94.2.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch fetch.3 ftp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2007 16:38:24 -0000 Dag-Erling Smørgrav wrote: > Nate Lawson writes: >> Could it be possible to check the values from the URL used to derive >> TYPE for RETR and then if it's the same as the value for MDTM, don't >> reissue it? Same for MODE. > > I suggest you look at the code. We *do* derive the TYPE value from > the URL. We do *not* trust the server state to be consistent from one > request to another. MDTM and RETR are two separate requests. Sorry, my message might have been unclear. I've looked at the code. > We *could* change the code to remember the last TYPE and MODE it > issued for the current server, and not issue new ones unnecessarily, > but we're quickly getting to the point where the FTP code needs a > major cleanup, at least when it comes to connection caching. This is what I was suggesting. I'll look into patching the current code to do this. If it's too hard, I'll skip it. -- Nate