From nobody Fri Dec 10 01:38:03 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 864C218DC355; Fri, 10 Dec 2021 01:38:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J9D7H1q6qz4l8j; Fri, 10 Dec 2021 01:38:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1E2EF11E8C; Fri, 10 Dec 2021 01:38:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1BA1c3Bb080743; Fri, 10 Dec 2021 01:38:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1BA1c3GN080742; Fri, 10 Dec 2021 01:38:03 GMT (envelope-from git) Date: Fri, 10 Dec 2021 01:38:03 GMT Message-Id: <202112100138.1BA1c3GN080742@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alexander Motin Subject: git: e06c67eef8fa - main - hptiop: Remove Giant locking around ioctls. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mav X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e06c67eef8faae3322c06056960562fde88fd7aa Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639100283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2gBnafT2P6SleGhkG0wjPnJddfIopySo+TNYbgaYhfk=; b=HO6rhJWD8Uzuoh3cO288ZWr66nuIPxaTTpWV1WdB4lRE3J/TuWh1snAkICBfnGVNbogqaN o6RWfYSBWMYqcP1yG1j4NKLoMFfrKpkePIWmX306GZe7Ux7iJii05vPUjDRZ6sNL3SlIVR 38IEAp+270euoNprlQvs6neVaay1KS2HPhBdEOtyNCBfdO5/m5whAjqu4x8vPbZ6oTLKyo JLRB5KbN1V7nRz2ol6wMeR7Pi+zi2fACu/DiJCTwRjik5saQtDwXUYl9y2Eau4eOFZOVTB UTHLJYrbLhMQfahbhKHwzavRCZ13zTj701PnqaCqtgmuJteH/vkoqfT+M1wPfg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639100283; a=rsa-sha256; cv=none; b=Am+dwvcdtDqROvHKxzE4M527Y9XMxnZUTWvnoqlrx23Whw5hQ4a4UjGEBaukX5op27qBLk PxOyu+4HVQT97OvoqfyqnDONMbn2o/AsPANVRcCS8dS4PAkw4ncP8cJeUVMd7VDQV8Tmei FwOP3W1y8ER8/m2kZ6WHIMHvpRLOcUE3IL3QoDa+RJfiUzNsW5tSRaf+xJY4IQWDseqkWN tbgWn2YecVLuwEJbREP99/5i8iUjC/F6vQeVqM0wiUfJAc2c+6x3F/HURBAk3mEFY0Vsr5 Tq78b5u9v27wZ6sI0Y+k6U1bwqJ/Ait6XdxVfIQKMizOwItaHezIx3ghLOFl7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mav: URL: https://cgit.FreeBSD.org/src/commit/?id=e06c67eef8faae3322c06056960562fde88fd7aa commit e06c67eef8faae3322c06056960562fde88fd7aa Author: Alexander Motin AuthorDate: 2021-12-10 01:35:21 +0000 Commit: Alexander Motin CommitDate: 2021-12-10 01:35:21 +0000 hptiop: Remove Giant locking around ioctls. The methods have their own locking and don't require Giant. MFC after: 2 weeks --- sys/dev/hptiop/hptiop.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/dev/hptiop/hptiop.c b/sys/dev/hptiop/hptiop.c index 300d10ff57e1..773b30948ed9 100644 --- a/sys/dev/hptiop/hptiop.c +++ b/sys/dev/hptiop/hptiop.c @@ -214,8 +214,6 @@ static int hptiop_ioctl(ioctl_dev_t dev, u_long cmd, caddr_t data, int ret = EFAULT; struct hpt_iop_hba *hba = hba_from_dev(dev); - mtx_lock(&Giant); - switch (cmd) { case HPT_DO_IOCONTROL: ret = hba->ops->do_ioctl(hba, @@ -225,9 +223,6 @@ static int hptiop_ioctl(ioctl_dev_t dev, u_long cmd, caddr_t data, ret = hptiop_rescan_bus(hba); break; } - - mtx_unlock(&Giant); - return ret; }