Date: Fri, 10 Dec 2021 01:38:03 GMT From: Alexander Motin <mav@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: e06c67eef8fa - main - hptiop: Remove Giant locking around ioctls. Message-ID: <202112100138.1BA1c3GN080742@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by mav: URL: https://cgit.FreeBSD.org/src/commit/?id=e06c67eef8faae3322c06056960562fde88fd7aa commit e06c67eef8faae3322c06056960562fde88fd7aa Author: Alexander Motin <mav@FreeBSD.org> AuthorDate: 2021-12-10 01:35:21 +0000 Commit: Alexander Motin <mav@FreeBSD.org> CommitDate: 2021-12-10 01:35:21 +0000 hptiop: Remove Giant locking around ioctls. The methods have their own locking and don't require Giant. MFC after: 2 weeks --- sys/dev/hptiop/hptiop.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/dev/hptiop/hptiop.c b/sys/dev/hptiop/hptiop.c index 300d10ff57e1..773b30948ed9 100644 --- a/sys/dev/hptiop/hptiop.c +++ b/sys/dev/hptiop/hptiop.c @@ -214,8 +214,6 @@ static int hptiop_ioctl(ioctl_dev_t dev, u_long cmd, caddr_t data, int ret = EFAULT; struct hpt_iop_hba *hba = hba_from_dev(dev); - mtx_lock(&Giant); - switch (cmd) { case HPT_DO_IOCONTROL: ret = hba->ops->do_ioctl(hba, @@ -225,9 +223,6 @@ static int hptiop_ioctl(ioctl_dev_t dev, u_long cmd, caddr_t data, ret = hptiop_rescan_bus(hba); break; } - - mtx_unlock(&Giant); - return ret; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202112100138.1BA1c3GN080742>