From owner-svn-src-stable@FreeBSD.ORG Fri Mar 11 22:54:00 2011 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8EA6F106566B; Fri, 11 Mar 2011 22:54:00 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 645C48FC17; Fri, 11 Mar 2011 22:53:58 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id AAA17865; Sat, 12 Mar 2011 00:53:55 +0200 (EET) (envelope-from avg@freebsd.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1PyBDX-000JqL-1p; Sat, 12 Mar 2011 00:53:55 +0200 Message-ID: <4D7AA801.5050503@freebsd.org> Date: Sat, 12 Mar 2011 00:53:53 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110308 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: Kostik Belousov References: <201103111927.p2BJRVu3091029@svn.freebsd.org> <20110311195046.GQ78089@deviant.kiev.zoral.com.ua> In-Reply-To: <20110311195046.GQ78089@deviant.kiev.zoral.com.ua> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r219526 - stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2011 22:54:00 -0000 on 11/03/2011 21:50 Kostik Belousov said the following: > On Fri, Mar 11, 2011 at 07:27:31PM +0000, Andriy Gapon wrote: >> Author: avg >> Date: Fri Mar 11 19:27:31 2011 >> New Revision: 219526 >> URL: http://svn.freebsd.org/changeset/base/219526 >> >> Log: >> use even larger stack size for ZFS txg_sync_thread >> >> While the stack size was larger than the default stack size on i386, it >> was smaller than the default stack size on amd64 and apparently that >> wasn't enough. So, bump the size to 4 pages. Upcoming ZFSv28 code uses >> 8 pages for this stack size. >> >> This is a direct commit to stable/8. >> >> PR: kern/154681 >> Discussed with: pjd >> >> Modified: >> stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c >> >> Modified: stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c >> ============================================================================== >> --- stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c Fri Mar 11 19:21:42 2011 (r219525) >> +++ stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c Fri Mar 11 19:27:31 2011 (r219526) >> @@ -146,7 +146,7 @@ txg_sync_start(dsl_pool_t *dp) >> * 32-bit x86. This is due in part to nested pools and >> * scrub_visitbp() recursion. >> */ >> - tx->tx_sync_thread = thread_create(NULL, 12<<10, txg_sync_thread, >> + tx->tx_sync_thread = thread_create(NULL, 16<<10, txg_sync_thread, >> dp, 0, &p0, TS_RUN, minclsyspri); >> >> mutex_exit(&tx->tx_sync_lock); > What about architectures where PAGE_SIZE != 4096 ? > We have ptoa() macro. I agree, but this is not the moment when the style that you comment on was introduced. So, it's better to review (and fix) the code in head. -- Andriy Gapon