From owner-svn-src-stable@freebsd.org Mon Mar 6 21:06:22 2017 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FBF9CFC456; Mon, 6 Mar 2017 21:06:22 +0000 (UTC) (envelope-from David.Somayajulu@cavium.com) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0048.outbound.protection.outlook.com [104.47.36.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 13B9B1D00; Mon, 6 Mar 2017 21:06:21 +0000 (UTC) (envelope-from David.Somayajulu@cavium.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=I7a8VKOASLE/EQ7JP78AhnaOEKofEHVV86M/RTuOgcI=; b=V+S3kqxd0xlwza+qyy7Q46JmoXqlfHFRU3LEzdQfLqYBLm5bhPMDASfuBgJTtngG1YRPbc16uH0OOZB96Ccp45Rt4wD9yFOVoUDkXO9CrxdJLli1/A68E7me5QwMzla0j5sTbxvPhUnol2LxFYCJpz0Q9RG9lzx+PtcUiPo1VWs= Received: from BY2PR07MB1474.namprd07.prod.outlook.com (10.162.76.152) by BY2PR07MB1476.namprd07.prod.outlook.com (10.162.76.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Mon, 6 Mar 2017 21:06:19 +0000 Received: from BY2PR07MB1474.namprd07.prod.outlook.com ([10.162.76.152]) by BY2PR07MB1474.namprd07.prod.outlook.com ([10.162.76.152]) with mapi id 15.01.0947.018; Mon, 6 Mar 2017 21:06:19 +0000 From: "Somayajulu, David" To: "rgrimes@freebsd.org" , David C Somayajulu CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-stable@freebsd.org" , "svn-src-stable-11@freebsd.org" Subject: RE: svn commit: r314789 - stable/11/sys/dev/qlxgbe Thread-Topic: svn commit: r314789 - stable/11/sys/dev/qlxgbe Thread-Index: AQHSlrfafKZCJ8vOekmOy1SFHvGajqGISesAgAAC8IA= Date: Mon, 6 Mar 2017 21:06:19 +0000 Message-ID: References: <201703062025.v26KPYSZ043721@repo.freebsd.org> <201703062053.v26KrG3S090402@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201703062053.v26KrG3S090402@pdx.rh.CN85.dnsmgr.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=cavium.com; x-originating-ip: [198.186.0.2] x-ms-office365-filtering-correlation-id: 3a10dd6a-1f4f-4bd7-2e6a-08d464d4a2d8 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BY2PR07MB1476; x-microsoft-exchange-diagnostics: 1; BY2PR07MB1476; 7:IO14m33E86Ym88FjMJG2s99HFyZrIucvtqH1br1XbpfWpnxG4yZYpWVdJNh2+d+kE+YKiDvdbSdF5JCo+ZGTyKicA9tUfsKh28QTPjN9v42XmR/3PB/YHm/eNwpVPlquu3J1XQKmBj2CYShSqMeLFysKki5mz7CUOjG+rjz9H3EOHY8O4Hq8nER2WK5h+qzXaevVgX3BERcQaxhhwr7efy/K5izCBi/go5ELLr9ZvUfTTmpWRWaDVDAcigyy9wBunV8YzyiZ8efzn//Nz2DyaU1E3UYQImDUBBgYBjDswwezgDYThdgiyc0Ibc1J6taW6avD20f8nNN9eYhH49Fxzg== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(56005881305849); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(20161123558025)(6072148); SRVR:BY2PR07MB1476; BCL:0; PCL:0; RULEID:; SRVR:BY2PR07MB1476; x-forefront-prvs: 0238AEEDB0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(377454003)(13464003)(3660700001)(2906002)(4326008)(92566002)(6116002)(7696004)(106116001)(305945005)(74316002)(7736002)(9686003)(3280700002)(25786008)(2950100002)(189998001)(6506006)(53936002)(5660300001)(102836003)(3846002)(86362001)(38730400002)(77096006)(54356999)(6246003)(50986999)(76176999)(54906002)(6306002)(55016002)(53546006)(2501003)(66066001)(122556002)(450100001)(8676002)(8936002)(2900100001)(81166006)(33656002)(229853002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB1476; H:BY2PR07MB1474.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2017 21:06:19.1034 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB1476 X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 21:06:22 -0000 Hi Rodney, I was worried about the same as well. The reason it looks funky is that the= following two lines have a 8 spaces instead of a tab. > bus_dmamem_free(dma_buf->dma_tag, dma_buf->dma_b, dma_buf->dma_m= ap); > bus_dma_tag_destroy(dma_buf->dma_tag); While=20 > + bus_dmamap_unload(dma_buf->dma_tag, dma_buf->dma_map); Uses a tab instead.=20 Thanks David S. -----Original Message----- From: Rodney W. Grimes [mailto:freebsd@pdx.rh.CN85.dnsmgr.net]=20 Sent: Monday, March 06, 2017 12:53 PM To: David C Somayajulu Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-stable@fre= ebsd.org; svn-src-stable-11@freebsd.org Subject: Re: svn commit: r314789 - stable/11/sys/dev/qlxgbe > Author: davidcs > Date: Mon Mar 6 20:25:33 2017 > New Revision: 314789 > URL: https://svnweb.freebsd.org/changeset/base/314789 >=20 > Log: > MFC r314062 > add bus_dmamap_unload in ql_free_dmabuf() >=20 > Modified: > stable/11/sys/dev/qlxgbe/ql_os.c > Directory Properties: > stable/11/ (props changed) >=20 > Modified: stable/11/sys/dev/qlxgbe/ql_os.c=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- stable/11/sys/dev/qlxgbe/ql_os.c Mon Mar 6 19:55:07 2017 (r314788) > +++ stable/11/sys/dev/qlxgbe/ql_os.c Mon Mar 6 20:25:33 2017 (r314789) > @@ -735,6 +735,7 @@ ql_alloc_dmabuf_exit: > void > ql_free_dmabuf(qla_host_t *ha, qla_dma_t *dma_buf) { > + bus_dmamap_unload(dma_buf->dma_tag, dma_buf->dma_map); > bus_dmamem_free(dma_buf->dma_tag, dma_buf->dma_b, dma_buf->dma_m= ap); > bus_dma_tag_destroy(dma_buf->dma_tag); > } That looks as if this file has incorrect leading white space? --=20 Rod Grimes rgrimes@freebsd.= org