From owner-svn-ports-head@FreeBSD.ORG  Sun Feb  9 13:52:57 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7B46B59D;
 Sun,  9 Feb 2014 13:52:57 +0000 (UTC)
Received: from prod2.absolight.net (mx3.absolight.net
 [IPv6:2a01:678:2:100::25])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 39E45178A;
 Sun,  9 Feb 2014 13:52:57 +0000 (UTC)
Received: from prod2.absolight.net (localhost [127.0.0.1])
 by prod2.absolight.net (Postfix) with ESMTP id D7CC9BDC5A;
 Sun,  9 Feb 2014 14:52:55 +0100 (CET)
Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205])
 by prod2.absolight.net (Postfix) with ESMTPA id B6154BDC56;
 Sun,  9 Feb 2014 14:52:55 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by atuin.in.mat.cc (Postfix) with ESMTP id 3CAF3CE45666;
 Sun,  9 Feb 2014 14:52:55 +0100 (CET)
Date: Sun, 09 Feb 2014 14:52:54 +0100
From: Mathieu Arnold <mat@FreeBSD.org>
To: Emanuel Haupt <ehaupt@FreeBSD.org>
Subject: Re: svn commit: r343457 - head/audio/p5-Shout
Message-ID: <EC011389057E119CB2996C3C@atuin.in.mat.cc>
In-Reply-To: <20140209143756.c1bc46e172d5d5c8979787fc@FreeBSD.org>
References: <201402091101.s19B1aPh072112@svn.freebsd.org>
 <1E1640591FF296C66F82EF62@atuin.in.mat.cc>
 <20140209131626.ad5097b391ebb1e6d738e28a@FreeBSD.org>
 <D51FCA4F34828A264C471DCA@atuin.in.mat.cc>
 <20140209143756.c1bc46e172d5d5c8979787fc@FreeBSD.org>
X-Mailer: Mulberry/4.0.8 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Feb 2014 13:52:57 -0000

+--On 9 f=C3=A9vrier 2014 14:37:56 +0100 Emanuel Haupt <ehaupt@FreeBSD.org>
wrote:
|> Yes, and like the wiki[1] says, unless there's a tremendous number of
|> files and the IO hit is pretty severe you should install them always.
|=20
| So you agree with me that the inclusion is required?

Nope, the opposite. The wiki says: "The DOCS/EXAMPLES .if blocks can be
made unconditional, except in cases when installed files are big enough to
cause significant I/O overhead."=20

In that case, you should have removed the conditional install of the files,
so that they always get staged, and save make of having to parse
bsd.port.mk twice :-)

|> (Also, if those are examples, they should go in EXAMPLESDIR)
|=20
| I was simply looking at the aspect of converting the port to support
| staging. I don't know if the application requires the files to be
| installed in EXAMPLESDIR or DOCSDIR.

If they're manually installed by the port, that is, not needed, and they're
called example* you can safely assume that they're examples, and thus, need
to go into the examples directory :-)

--=20
Mathieu Arnold