From owner-freebsd-stable@FreeBSD.ORG Fri Jul 3 14:28:41 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 06B701065678 for ; Fri, 3 Jul 2009 14:28:41 +0000 (UTC) (envelope-from rick@havokmon.com) Received: from dotsevenseven.vfemail.net (dotsevenseven.vfemail.net [69.11.239.77]) by mx1.freebsd.org (Postfix) with ESMTP id A35668FC13 for ; Fri, 3 Jul 2009 14:28:40 +0000 (UTC) (envelope-from rick@havokmon.com) Received: (qmail 22236 invoked by uid 0); 3 Jul 2009 14:28:38 -0000 Received: by simscan 1.1.0 ppid: 22229, pid: 22233, t: 0.0137s scanners:none Received: from unknown (HELO ?172.16.100.182?) (cmlja0BoYXZva21vbi5jb20=@NjkuMTEuMjM5LjY2) by mail.vfemail.net with ESMTPA; 3 Jul 2009 14:28:38 -0000 From: Rick Romero To: Mike Andrews In-Reply-To: References: <20090630155437.GA42783@a91-153-125-115.elisa-laajakaista.fi> <4A4A6358.1010806@bit0.com> <20090701090818.GA1391@a91-153-125-115.elisa-laajakaista.fi> Content-Type: text/plain Organization: VF IT Services Date: Fri, 03 Jul 2009 09:26:55 -0500 Message-Id: <1246631215.3268.10.camel@rickxp> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 Content-Transfer-Encoding: 7bit Cc: Jaakko Heinonen , freebsd-stable@freebsd.org, Andriy Gapon , Gavin Atkinson Subject: Re: kern/135412: [zfs] [nfs] zfs(v13)+nfs and open(..., O_WRONLY|O_CREAT|O_EXCL, ...) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2009 14:28:41 -0000 On Thu, 2009-07-02 at 16:08 -0400, Mike Andrews wrote: > On Wed, 1 Jul 2009, Danny Braniss wrote: > > >> On 2009-06-30, Mike Andrews wrote: > >>> Jaakko Heinonen wrote: > >>>> On 2009-06-30, Danny Braniss wrote: > >>>>> This pr is realy holding me back, I can't upgrade this server, and > >>>>> telling serveral tens of users to us cp, etc is not an option. The open > >>>>> works fine if not using O_EXCL. > >>>> > >>>> I guess that r185586 needs to be MFCd to stable/7. Here's an untested > >>>> patch against stable/7: > >>> > >>> The patch doesn't help over here, sorry. > >>> > >>> Simply doing 'touch' or 'mv' to an NFSv3 mount (using either a v6 or v13 > >>> zpool) is the test case I've been using; touch doesn't even use O_EXCL as > >>> far as I can tell. > >> > >> I could reproduce the problem with O_EXCL and verified that the patch > >> fixes it. However I couldn't reproduce the problem you are seeing with > >> touch and mv. > > > > same here, touch worked before too - so i think it's unrelated, > > btw, it seems that the problem does not exist on i386, though > > I'm pretty sure I tried there too, oh well, > > > > thanks! > > danny > > I'm not sure if what was commited to stable/7 yesterday is substantially > different from that patch (and if not, what in the world I was doing > wrong/stupid in testing), but everything now works for me... thanks :) Looks like it's working pretty well to me. It's almost not worth mentioning, but I have an old FreeBSD 4.8 server (which is the midst of being retired) that is still having an issue related to this. When I edit a file with vim 7.0, it creates the swapfile with no perms (which causes it to complain that the file already exists, and not clean up after itself) This only occurs from a 4.8 client, not 5.2.1, 6.2, or 7.2. Vim is the only program that replicates the problem on that box. touch works, mv works, procmail works. I only mention because maybe there's another OS, that's still supported, that might still have the same issues. Rick