From owner-p4-projects@FreeBSD.ORG Tue May 25 15:18:43 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 563081065679; Tue, 25 May 2010 15:18:43 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0F0641065674; Tue, 25 May 2010 15:18:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D50B88FC21; Tue, 25 May 2010 15:18:42 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 8716446B97; Tue, 25 May 2010 11:18:42 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 7FA1B8A021; Tue, 25 May 2010 11:18:41 -0400 (EDT) From: John Baldwin To: Efstratios Karatzas Date: Tue, 25 May 2010 08:58:24 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201005241406.o4OE6v5B051548@repoman.freebsd.org> In-Reply-To: <201005241406.o4OE6v5B051548@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201005250858.24659.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 25 May 2010 11:18:41 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.4 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Perforce Change Reviews Subject: Re: PERFORCE change 178714 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 May 2010 15:18:43 -0000 On Monday 24 May 2010 10:06:57 am Efstratios Karatzas wrote: > http://p4web.freebsd.org/@@178714?ac=10 > > Change 178714 by gpf@gpf_desktop on 2010/05/24 14:06:34 > > * the second parameter from VOP_VPTOCNP() should be vdrop()ed after > the call - done > * dont really need exclusive locks; now I use shared locks > * dir_ilookup() still only works for UFS, added a check so that the > function will return if the fs is not ufs > > Affected files ... > > .. //depot/projects/soc2010/gpf_audit/vn_fullpath_nocache.c#3 edit > > Differences ... > > ==== //depot/projects/soc2010/gpf_audit/vn_fullpath_nocache.c#3 (text+ko) ==== > > @@ -75,11 +75,18 @@ > KASSERT("dvp != NULL", "dir_ilookup: dvp == NULL"); > KASSERT("name != NULL", "dir_ilookup: name == NULL"); > > + /* XXXgpf: temporary, must be a better way to check this than f_type or f_fstypename */ > + if (strcmp(vp->v_mount->mnt_stat.f_fstypename, "ufs")) { > + uprintf("only ufs supported\n"); > + return 1; > + } > + The normal way to handle something like this is by moving the filesystem-specific functionality into a new VOP. Alternatively, the mount point could grow a new flag (such as MNTK_MPSAFE or MNTK_LOOKUP_SHARED) to indicate that a specific mount supports an optional feature or capability. -- John Baldwin