From owner-svn-src-all@freebsd.org Fri May 20 19:53:24 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CFA6CB44002 for ; Fri, 20 May 2016 19:53:24 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm16.bullet.mail.bf1.yahoo.com (nm16.bullet.mail.bf1.yahoo.com [98.139.212.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 89CEC1E01 for ; Fri, 20 May 2016 19:53:24 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1463774002; bh=f58/QHs3yfqDNqosNINtR7fBwhF+y8sEfYSuQ2Ydrrk=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=pLaLC+32R1ETO78vrWgTxHfMIZ73lr3WQr6u8OEG1jROuKwPmJ0c+f3IVI/Qaogwl/k7C4MI8iKqg8r273J4jbFZYxF/1PP6slhVuKO4RCGaE9ER8581DH9Rizp+BUID7Lj3W91AgIwfs+Ij4tAMvcLAMhL5oiUKpSf50NTPm0Xfn4OHKrKLa9h9tu3L+f4q38RRxU1daKTSU7R6EZoPiwF95q7BUIqzO6lNN2tNH+bpo3v+qTqS/xTokTOCOvQVfix97AEh2G8odqsnI7pC9VpgdeFRPOl2F0IgaORFgAOlW2GEmqfpH7rp/RMJGQr+WkWlsVxOn98D/5KB02apIw== Received: from [66.196.81.171] by nm16.bullet.mail.bf1.yahoo.com with NNFMP; 20 May 2016 19:53:22 -0000 Received: from [98.139.211.192] by tm17.bullet.mail.bf1.yahoo.com with NNFMP; 20 May 2016 19:53:22 -0000 Received: from [127.0.0.1] by smtp201.mail.bf1.yahoo.com with NNFMP; 20 May 2016 19:53:22 -0000 X-Yahoo-Newman-Id: 688695.78915.bm@smtp201.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: uUz01R8VM1knrzWhR6pXq1Y8VeV4MkA_fR91eSmUaoMYpo1 oB4JJkXa0VB3yspsgvM41Yc.0jqm..WQVM8MLqPLm2IhmQOSxFd5PDixPCAW IMUEE2wcZzdeL3DnuU82xZNNV0Td80oBxL6Ul90l4pLtrEgDhM_xkBuOnV0i fpa10JwR1gUFiS8wJiI_X__XOKZVcyDAl44sbny0C1SCnGyZgJsJ_6yL6QVg DKRm1kWg4IoMIL5L2LdrR2laAc_uZhVkZmOmEFAq2sbIBhUv_svUjUKPAUOA CVjBwNeZTcaYt5BC9Z9rNLSTu4494WnnFUTocuEvYDN50.gNT0Ucdbq5ic3O VWdwpWD6RPXsZP0MjbBYBoidvK32CRZbhTsPYPKCBvdjfcReyJ_y8Sg5RAL4 4n.R8YWzXfVVC3j_3NYydzetTPEtfaaVIRDOY49vfiPH.D5VbVOOsZQeF9Ls cRvcznpT8oD5ruO702GQauAf8bDUzafkywDKRKVpdQyNy1LPMjnhSlBILkE0 lkL6nrLitHM5zyDMPRro0j6_.JLsR4bk- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r300322 - head/bin/ed To: Ed Schouten References: <201605201910.u4KJAT13015624@repo.freebsd.org> Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: <1555e0da-830b-d06b-080b-a8176a7db67d@FreeBSD.org> Date: Fri, 20 May 2016 14:53:32 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2016 19:53:24 -0000 On 05/20/16 14:31, Ed Schouten wrote: > 2016-05-20 21:10 GMT+02:00 Pedro F. Giffuni : >> /* initialize the padding vector */ >> for (i = 0; i < 8; i++) >> - pvec[i] = (char) (arc4random() % 256); >> + pvec[i] = (char)arc4random_uniform(256); > > This could be simplified to just calling arc4random_buf() on pvec, right? > Hmm ... Yes. FWIW, ed(1) needs a bunch of cleanups. OpenBSD removed the DES code altogether. Pedro.