From owner-cvs-src@FreeBSD.ORG Tue Nov 30 19:23:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66B3816A4CE; Tue, 30 Nov 2004 19:23:27 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85C6B43D2F; Tue, 30 Nov 2004 19:23:26 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iAUJNL2Q085630; Tue, 30 Nov 2004 21:23:21 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 13608-18; Tue, 30 Nov 2004 21:23:20 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iAUJNKtu085627 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 30 Nov 2004 21:23:20 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id iAUJNGiL003997; Tue, 30 Nov 2004 21:23:16 +0200 (EET) (envelope-from ru) Date: Tue, 30 Nov 2004 21:23:16 +0200 From: Ruslan Ermilov To: Poul-Henning Kamp Message-ID: <20041130192316.GB3845@ip.net.ua> References: <20041130090553.GA691@ip.net.ua> <52202.1101838031@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tjCHc7DPkfUGtrlw" Content-Disposition: inline In-Reply-To: <52202.1101838031@critter.freebsd.dk> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: Doug Barton cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/mount mntopts.h mount.8 mount.c src/sbin/mount_std mount_std.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2004 19:23:27 -0000 --tjCHc7DPkfUGtrlw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 30, 2004 at 07:07:11PM +0100, Poul-Henning Kamp wrote: > In message <20041130090553.GA691@ip.net.ua>, Ruslan Ermilov writes: >=20 > >> FYI, this commit seems to have broken my line in fstab which has worke= d f > >or > >> a long time: > >>=20 > >> md /tmp mfs rw,-s16m,noatime,nosuid,nodev = 2 0 > >>=20 > >> Is it useful for the nodev option to cause a hard failure here? Note, = I'm > >> not arguing against either change, just pointing out a side effect. > >>=20 > >There's no longer a "nodev" option, please ask Poul-Henning for details.= ;) >=20 > The reason I did not remove MNT_NODEV but only #defined it to zero was > to make it silently ignored. >=20 To make it silently ignored, you should have left it with its old value. Most operations with MNT_* constants are "bitwise AND", and so zero was not a good choice. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --tjCHc7DPkfUGtrlw Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBrMikqRfpzJluFF4RAvKfAJ99HKm5JF4MBxwc49R/RBk+3JSH6wCaAx5A 4ytEEnE2qzEMVnAedRMnn3g= =F6G0 -----END PGP SIGNATURE----- --tjCHc7DPkfUGtrlw--