From owner-svn-src-all@FreeBSD.ORG Sat Sep 10 14:28:17 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EF54D1065670; Sat, 10 Sep 2011 14:28:16 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 8EB2A8FC12; Sat, 10 Sep 2011 14:28:16 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p8AESCUr060827 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 10 Sep 2011 17:28:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p8AESCD9064768; Sat, 10 Sep 2011 17:28:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p8AESCBL064767; Sat, 10 Sep 2011 17:28:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 10 Sep 2011 17:28:12 +0300 From: Kostik Belousov To: Hans Petter Selasky Message-ID: <20110910142812.GO17489@deviant.kiev.zoral.com.ua> References: <3406F3E2-56E6-47FF-8A60-10DD9F3B3D10@FreeBSD.org> <201109101540.16656.hselasky@c2i.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hp0y2R9lOm5A3xbf" Content-Disposition: inline In-Reply-To: <201109101540.16656.hselasky@c2i.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: "src-committers@freebsd.org" , re@freebsd.org, "svn-src-stable@freebsd.org" , "svn-src-all@freebsd.org" , "Robert N. M. Watson" , "svn-src-stable-8@freebsd.org" Subject: Re: Request for patch approval (Re: svn commit: r225458 - in stable/8/sys: dev/usb dev/usb/quirk dev/usb/storage sys) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Sep 2011 14:28:17 -0000 --hp0y2R9lOm5A3xbf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 10, 2011 at 03:40:16PM +0200, Hans Petter Selasky wrote: >=20 > > Right -- exactly my point. If this change breaks third-party compiled U= SB > > device drivers, then our current approach to device driver KBIs does not > > allow it to be MFC'd in this form. Are there ways you can reformulate t= he > > change to avoid breaking those drivers? Sometimes this can be done by > > adding new symbols, rather than replacing currently symbols, although > > mileage varies. >=20 > Hi, >=20 > Here is my proposal: >=20 > Implement test for automatic quirks in function which has access to the U= SB=20 > device structure. This decouples the structure change in "struct=20 > usbd_lookup_info". >=20 > The only structure which needs change is "struct usb_device". In 9-curren= t=20 > this structure will be kept as is. In 8-stable the new element will be mo= ved=20 > to the end of the structure like suggested, and then there shouldn't be a= ny=20 > problems. >=20 > Please find patches attached. >=20 > --HPS >=20 > Commit message: >=20 > Refactor auto-quirk solution so that we break as few external > drivers as possible. >=20 > PR: usb/160299 > Approved by: re (kib) > Suggested by: rwatson > MFC after: 0 days >=20 First, can you, please, regenerate the diff for stable/8 against the code before r225458 ? I want to read diff to see ABI change, assuming r225458 was not done at all. Second, you cannot decrement __FreeBSD_version. In fact, you shall increment it once more in the patch for stable/8. --hp0y2R9lOm5A3xbf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk5rc/sACgkQC3+MBN1Mb4jVFACgjL7UAnc6xBYTPg6siFESXQWR u1AAoOYptIt4IoKezFbzPJdrrOKgqfcm =jOV4 -----END PGP SIGNATURE----- --hp0y2R9lOm5A3xbf--