From owner-svn-src-all@freebsd.org Fri Aug 17 15:26:33 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05FC01072396; Fri, 17 Aug 2018 15:26:33 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AEF3383610; Fri, 17 Aug 2018 15:26:32 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4C995278E6; Fri, 17 Aug 2018 15:26:32 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f178.google.com with SMTP id y17-v6so6663782ljy.8; Fri, 17 Aug 2018 08:26:32 -0700 (PDT) X-Gm-Message-State: AOUpUlGntqZI/uzACsj874Mwj7HR1ZnIBmoC6VAHpQYMe1Zgn7JkXySG dFQhl2VoQp8BJ8poMwFDu84a6aC1zDOmnblHzqI= X-Google-Smtp-Source: AA+uWPyJh2mNHnoRsXMU1PNCF7DVU9ys5G0HXPNxyuO6WFmMVQTOakEIRDhvMq64tXibzZfBK0Hrjwkgrlrdylj+UTo= X-Received: by 2002:a2e:144f:: with SMTP id 15-v6mr25839124lju.122.1534519590831; Fri, 17 Aug 2018 08:26:30 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:5742:0:0:0:0:0 with HTTP; Fri, 17 Aug 2018 08:26:10 -0700 (PDT) In-Reply-To: <201808171524.w7HFOdQi059798@pdx.rh.CN85.dnsmgr.net> References: <201808170415.w7H4Fp7D046775@repo.freebsd.org> <201808171524.w7HFOdQi059798@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Fri, 17 Aug 2018 10:26:10 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r337956 - in head: . bin/ls To: "Rodney W. Grimes" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2018 15:26:33 -0000 On Fri, Aug 17, 2018 at 10:24 AM, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> Author: kevans >> Date: Fri Aug 17 04:15:51 2018 >> New Revision: 337956 >> URL: https://svnweb.freebsd.org/changeset/base/337956 >> >> Log: >> ls(1): Add --color=when >> >> --color may be set to one of: 'auto', 'always', and 'never'. >> >> 'auto' is the default behavior- output colors only if -G or COLORTERM are > > Why different than coreutils ls? Default for coreutils is none. I guess this was worded poorly and you skipped both the review and reading the diff... this is still contingent on environment variables or -G being specified. >> set, and only if stdout is a tty. >> >> 'always' is a new behavior- output colors always. termcap(5) will be >> consulted unless TERM is unset or not a recognized terminal, in which case >> ls(1) will fall back to explicitly outputting ANSI escape sequences. >> >> 'never' to turn off any environment variable and -G usage. > Why different than core utils? Coreutils uses none. I guess this was worded poorly and you skipped both the review and reading the diff... this is still contingent on environment variables or -G being specified. Thanks, Kyle Evans