Date: Tue, 25 Sep 2001 13:43:32 +0300 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Will Andrews <will@physics.purdue.edu> Cc: lioux@uol.com.br, FreeBSD-ports@FreeBSD.org, portmgr@FreeBSD.org, pat@databits.net, fenner@FreeBSD.org, kris@FreeBSD.org, green@FreeBSD.org, knu@FreeBSD.org, julian@FreeBSD.org, petef@FreeBSD.org, cwasser@v-wave.com, sjh-cl@horan.net.au, john_m_cooper@yahoo.com, matt@ipperformance.com Subject: Re: review plz MASTER_SITES_n (ala OpenBSD) patch for bsd.port.mk Message-ID: <3BB05FD4.3E235748@FreeBSD.org> References: <20010923055224.A93855@exxodus.fedaykin.here> <E15l7Nf-00072f-00@mx10.port.ru> <20010923133030.K69123@curie.physics.purdue.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Will Andrews wrote: > On Sun, Sep 23, 2001 at 03:25:05PM +0400, Maxim Sobolev (sobomax@mail.ru) wrote: > > Thank you for a great work, it is really step in the right direction. > > Yeah! It is awesome! > I've reviewed the diff and I believe it is very well done. I'd > like to test a final version of this patch plus patches to the > various ports in my bento tree (mainly KDE and its dependneices) > and see how it goes. Any objections to this method of testing? > If someone else wants to add other ports for the sole purpose of > testing this patch, I'll do that too. > > > I have not reviewed the implementation yet, but the writeup is really > > interesting and well thought out. At the same time, I am not very happy > > with the resulting Makefile bloat, and have a quick idea, which may or > > may not be a better way out: > > I agree. > > > Why not in addition to postfixes in DISTFILES introduce the same > > postfixes in MASTER_SITES and MASTER_SITE_SUBDIR? This would allow > > to avoid introducing MASTER_SITES_foo, turning your example below > > into: > > I like this: > > > MASTER_SITES= http://master7/:n \ > > http://master1/:t http://master2/:t http://master3/%SUBDIR%/:t \ > > http://master4/:y http://master5/:y http://master6/%SUBDIR%/:y \ > > http://master8/:p > > DISTFILES= file1:t file2:y file3:n file4:o:p > > MASTER_SITE_SUBDIR= subdir:t subdir_test:y > > But, there's a small problem here. I believe ':' is a valid URI > character, and I believe _some_ places have actually used this > character. But I am not sure. Would it be possible to use a > different character for the delimiter? It would not a big problem, because in MASTER_SITES presence of postfix means absence of trailing `/' (hence it is easy to sort it out), while possibility to find `:' in the MASTER_SITE_SUBDIR is close to zero. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3BB05FD4.3E235748>