Date: Fri, 7 Jul 2023 12:29:38 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: "Hurling, Rainer" <rhurlin@freebsd.org> Cc: Raphael Kubo da Costa <rakuco@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used Message-ID: <CAFDf7UJ90-hVX3WePtD--tHb0HEeUrq6Y0mRezZ8kYYoDQL69g@mail.gmail.com> In-Reply-To: <45470f65-48c3-9a18-b7bd-26ce17160afd@gwdg.de> References: <202307050850.3658oPOA049562@gitrepo.freebsd.org> <CAFDf7UJRc4bd3XVq%2Bb7Za2cLN7h_hkN1mpPTGQiSajV1p9A=0g@mail.gmail.com> <ebcdf01a-2b73-39c3-b6e4-25659e53b1ca@gwdg.de> <e56d377d0985b86be2291b64bb3c686742283dde.camel@FreeBSD.org> <6cf6a5eb00dfac8358dfcb1e1d5b69f293c3e85a.camel@FreeBSD.org> <4701f862-7a0b-afab-48fd-a62b6f5ec308@gwdg.de> <CAFDf7UKJh%2BscZ-zkmwWUNeQbVB%2B42TQSN8-m102iChi8wg0WoA@mail.gmail.com> <4cc5665f-a4ef-a4ef-226a-a9a59b29f3a0@gwdg.de> <CAFDf7ULoQfRo4S45Fpwm9Ve4h0E%2Bd82z5SYrFopmcKFLOShrdw@mail.gmail.com> <45470f65-48c3-9a18-b7bd-26ce17160afd@gwdg.de>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] PORTREVISION=11: USE_CXXSTD=gnu++14 http://freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_12h12m14s/logs/eboard-1.1.3_11.log PORTREVISION=10: USE_CXXSTD=c++14 http://freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_09h44m48s/logs/eboard-1.1.3_10.log Both revs 10 and 11 runs OK. I've take a look at logs and it seems that glib2 deprecations could be the reason for c++17 build failures. Could you take a look at: https://cgit.freebsd.org/ports/commit/?id=e95c4bea425b3e3c49b63e0cf4eff24af40c574b it also includes link to mailing full discussion. This is what we should do when possible, fix the code as said in previous messages. Rainer Hurling <rhurlin@gwdg.de> escreveu no dia sexta, 7/07/2023 à(s) 10:53: > Am 07.07.23 um 10:59 schrieb Nuno Teixeira: > > Hello! > > > > I've bumped PORTREVISION to 10 so we can identify better each experiment > > build: > > > > PORTREVISION=10: USE_CXXSTD=c++14 > > build status: > > > http://freebsdrpi4.hopto.org/build.html?mastername=13Saarch64-main&build=2023-07-07_09h44m48s > < > http://freebsdrpi4.hopto.org/build.html?mastername=13Saarch64-main&build=2023-07-07_09h44m48s > > > > > > and when built I will do a run test. > > > > Oops, yes! > > > Shoud I test gnu++14 too? > > I accidentally provided a patch with c++14 that I had used for another > test of my own. Meant was gnu++14, so please feel free to test that one > too. Thanks! > > > > > > > > > > > Rainer Hurling <rhurlin@gwdg.de <mailto:rhurlin@gwdg.de>> escreveu no > > dia sexta, 7/07/2023 à(s) 06:42: > > > > Hi Nuno, > > > > Am 06.07.23 um 23:51 schrieb Nuno Teixeira: > > > Hello Rainer, > > > > > > Still, one more question: is it safe to remove > > USES=compiler:c++11-lang > > > for architectures other than amd64 and i386 and just use > > > USE_STDCXX=gnu++14. I have no way to test for arm, etc. > > > > > > > > > I've asked the same for compiler:c11 on mailing today. > > > My doubt is: is it neccessary using c11, c++11, etc when available > > > compilers support it or have capabilities for it? > > > > > > I can do poudriere testport and run test on a rpi4 running 13 > > stable, > > > just send me diff. > > > > Thanks for the offer. Here is a diff against games/eboard with the to > > changes: > > > > diff --git a/games/eboard/Makefile b/games/eboard/Makefile > > index 3f78f9e91874..ce399415cba8 100644 > > --- a/games/eboard/Makefile > > +++ b/games/eboard/Makefile > > @@ -20,10 +20,10 @@ LIB_DEPENDS= > > libfontconfig.so:x11-fonts/fontconfig \ > > libfreetype.so:print/freetype2 \ > > libpng.so:graphics/png > > > > -USES= compiler:c++11-lang gnome gstreamer perl5 pkgconfig > > shebangfix tar:bzip2 > > +USES= gnome gstreamer perl5 pkgconfig shebangfix tar:bzip2 > > # eboard 1.1.13 is not compatible with C++17, which is the > > default since > > # clang 16. This means ports depending on it also need to use at > > most > > C++14. > > -USE_CXXSTD= c++11 > > +USE_CXXSTD= c++14 > > USE_GITHUB= yes > > GH_ACCOUNT= fbergo > > USE_GNOME= cairo gdkpixbuf2 gtk20 > > > > > > It would be very nice if you could also look for arm, if the package > is > > still binary compatible compared to the unpatched version :) > > > > Thanks a lot ! > > > > Best wishes, > > Rainer > > > > > > > > Cheers, > > > > > > -- > > > Nuno Teixeira > > > FreeBSD Committer (ports) > > > > > > > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > > -- Nuno Teixeira FreeBSD Committer (ports) [-- Attachment #2 --] <div dir="ltr"><div><span class="gmail-im">PORTREVISION=11: USE_CXXSTD=gnu++14</span></div><div><a href="http://freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_12h12m14s/logs/eboard-1.1.3_11.log">http://freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_12h12m14s/logs/eboard-1.1.3_11.log</a></div><div><br></div><div><span class="gmail-im">PORTREVISION=10: USE_CXXSTD=c++14</span></div><div><a href="http://freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_09h44m48s/logs/eboard-1.1.3_10.log">http://freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_09h44m48s/logs/eboard-1.1.3_10.log</a></div><div><br></div><div>Both revs 10 and 11 runs OK.</div><div><br></div><div>I've take a look at logs and it seems that glib2 deprecations could be the reason for c++17 build failures.</div><div>Could you take a look at:</div><div><a href="https://cgit.freebsd.org/ports/commit/?id=e95c4bea425b3e3c49b63e0cf4eff24af40c574b">https://cgit.freebsd.org/ports/commit/?id=e95c4bea425b3e3c49b63e0cf4eff24af40c574b</a></div><div>it also includes link to mailing full discussion.</div><div><br></div><div>This is what we should do when possible, fix the code as said in previous messages.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Rainer Hurling <<a href="mailto:rhurlin@gwdg.de">rhurlin@gwdg.de</a>> escreveu no dia sexta, 7/07/2023 à(s) 10:53:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Am 07.07.23 um 10:59 schrieb Nuno Teixeira:<br> > Hello!<br> > <br> > I've bumped PORTREVISION to 10 so we can identify better each experiment <br> > build:<br> > <br> > PORTREVISION=10: USE_CXXSTD=c++14<br> > build status:<br> > <a href="http://freebsdrpi4.hopto.org/build.html?mastername=13Saarch64-main&build=2023-07-07_09h44m48s" rel="noreferrer" target="_blank">http://freebsdrpi4.hopto.org/build.html?mastername=13Saarch64-main&build=2023-07-07_09h44m48s</a>; <<a href="http://freebsdrpi4.hopto.org/build.html?mastername=13Saarch64-main&build=2023-07-07_09h44m48s" rel="noreferrer" target="_blank">http://freebsdrpi4.hopto.org/build.html?mastername=13Saarch64-main&build=2023-07-07_09h44m48s</a>><br>; > <br> > and when built I will do a run test.<br> > <br> <br> Oops, yes!<br> <br> > Shoud I test gnu++14 too?<br> <br> I accidentally provided a patch with c++14 that I had used for another <br> test of my own. Meant was gnu++14, so please feel free to test that one <br> too. Thanks!<br> <br> > <br> > <br> > <br> > <br> > Rainer Hurling <<a href="mailto:rhurlin@gwdg.de" target="_blank">rhurlin@gwdg.de</a> <mailto:<a href="mailto:rhurlin@gwdg.de" target="_blank">rhurlin@gwdg.de</a>>> escreveu no <br> > dia sexta, 7/07/2023 à(s) 06:42:<br> > <br> > Hi Nuno,<br> > <br> > Am 06.07.23 um 23:51 schrieb Nuno Teixeira:<br> > > Hello Rainer,<br> > ><br> > > Still, one more question: is it safe to remove<br> > USES=compiler:c++11-lang<br> > > for architectures other than amd64 and i386 and just use<br> > > USE_STDCXX=gnu++14. I have no way to test for arm, etc.<br> > ><br> > ><br> > > I've asked the same for compiler:c11 on mailing today.<br> > > My doubt is: is it neccessary using c11, c++11, etc when available<br> > > compilers support it or have capabilities for it?<br> > ><br> > > I can do poudriere testport and run test on a rpi4 running 13<br> > stable,<br> > > just send me diff.<br> > <br> > Thanks for the offer. Here is a diff against games/eboard with the to<br> > changes:<br> > <br> > diff --git a/games/eboard/Makefile b/games/eboard/Makefile<br> > index 3f78f9e91874..ce399415cba8 100644<br> > --- a/games/eboard/Makefile<br> > +++ b/games/eboard/Makefile<br> > @@ -20,10 +20,10 @@ LIB_DEPENDS=<br> > libfontconfig.so:x11-fonts/fontconfig \<br> > libfreetype.so:print/freetype2 \<br> > libpng.so:graphics/png<br> > <br> > -USES= compiler:c++11-lang gnome gstreamer perl5 pkgconfig<br> > shebangfix tar:bzip2<br> > +USES= gnome gstreamer perl5 pkgconfig shebangfix tar:bzip2<br> > # eboard 1.1.13 is not compatible with C++17, which is the<br> > default since<br> > # clang 16. This means ports depending on it also need to use at<br> > most<br> > C++14.<br> > -USE_CXXSTD= c++11<br> > +USE_CXXSTD= c++14<br> > USE_GITHUB= yes<br> > GH_ACCOUNT= fbergo<br> > USE_GNOME= cairo gdkpixbuf2 gtk20<br> > <br> > <br> > It would be very nice if you could also look for arm, if the package is<br> > still binary compatible compared to the unpatched version :)<br> > <br> > Thanks a lot !<br> > <br> > Best wishes,<br> > Rainer<br> > <br> > ><br> > > Cheers,<br> > ><br> > > --<br> > > Nuno Teixeira<br> > > FreeBSD Committer (ports)<br> > <br> > <br> > <br> > -- <br> > Nuno Teixeira<br> > FreeBSD Committer (ports)<br> <br> </blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><span style="color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committer (ports)</span></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJ90-hVX3WePtD--tHb0HEeUrq6Y0mRezZ8kYYoDQL69g>