Date: Fri, 7 Jul 2023 12:29:38 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: "Hurling, Rainer" <rhurlin@freebsd.org> Cc: Raphael Kubo da Costa <rakuco@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used Message-ID: <CAFDf7UJ90-hVX3WePtD--tHb0HEeUrq6Y0mRezZ8kYYoDQL69g@mail.gmail.com> In-Reply-To: <45470f65-48c3-9a18-b7bd-26ce17160afd@gwdg.de> References: <202307050850.3658oPOA049562@gitrepo.freebsd.org> <CAFDf7UJRc4bd3XVq%2Bb7Za2cLN7h_hkN1mpPTGQiSajV1p9A=0g@mail.gmail.com> <ebcdf01a-2b73-39c3-b6e4-25659e53b1ca@gwdg.de> <e56d377d0985b86be2291b64bb3c686742283dde.camel@FreeBSD.org> <6cf6a5eb00dfac8358dfcb1e1d5b69f293c3e85a.camel@FreeBSD.org> <4701f862-7a0b-afab-48fd-a62b6f5ec308@gwdg.de> <CAFDf7UKJh%2BscZ-zkmwWUNeQbVB%2B42TQSN8-m102iChi8wg0WoA@mail.gmail.com> <4cc5665f-a4ef-a4ef-226a-a9a59b29f3a0@gwdg.de> <CAFDf7ULoQfRo4S45Fpwm9Ve4h0E%2Bd82z5SYrFopmcKFLOShrdw@mail.gmail.com> <45470f65-48c3-9a18-b7bd-26ce17160afd@gwdg.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000006259db05ffe3f3de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable PORTREVISION=3D11: USE_CXXSTD=3Dgnu++14 http://freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_12h12m14s/logs= /eboard-1.1.3_11.log PORTREVISION=3D10: USE_CXXSTD=3Dc++14 http://freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_09h44m48s/logs= /eboard-1.1.3_10.log Both revs 10 and 11 runs OK. I've take a look at logs and it seems that glib2 deprecations could be the reason for c++17 build failures. Could you take a look at: https://cgit.freebsd.org/ports/commit/?id=3De95c4bea425b3e3c49b63e0cf4eff24= af40c574b it also includes link to mailing full discussion. This is what we should do when possible, fix the code as said in previous messages. Rainer Hurling <rhurlin@gwdg.de> escreveu no dia sexta, 7/07/2023 =C3=A0(s) 10:53: > Am 07.07.23 um 10:59 schrieb Nuno Teixeira: > > Hello! > > > > I've bumped PORTREVISION to 10 so we can identify better each experimen= t > > build: > > > > PORTREVISION=3D10: USE_CXXSTD=3Dc++14 > > build status: > > > http://freebsdrpi4.hopto.org/build.html?mastername=3D13Saarch64-main&buil= d=3D2023-07-07_09h44m48s > < > http://freebsdrpi4.hopto.org/build.html?mastername=3D13Saarch64-main&buil= d=3D2023-07-07_09h44m48s > > > > > > and when built I will do a run test. > > > > Oops, yes! > > > Shoud I test gnu++14 too? > > I accidentally provided a patch with c++14 that I had used for another > test of my own. Meant was gnu++14, so please feel free to test that one > too. Thanks! > > > > > > > > > > > Rainer Hurling <rhurlin@gwdg.de <mailto:rhurlin@gwdg.de>> escreveu no > > dia sexta, 7/07/2023 =C3=A0(s) 06:42: > > > > Hi Nuno, > > > > Am 06.07.23 um 23:51 schrieb Nuno Teixeira: > > > Hello Rainer, > > > > > > Still, one more question: is it safe to remove > > USES=3Dcompiler:c++11-lang > > > for architectures other than amd64 and i386 and just use > > > USE_STDCXX=3Dgnu++14. I have no way to test for arm, etc. > > > > > > > > > I've asked the same for compiler:c11 on mailing today. > > > My doubt is: is it neccessary using c11, c++11, etc when availab= le > > > compilers support it or have capabilities for it? > > > > > > I can do poudriere testport and run test on a rpi4 running 13 > > stable, > > > just send me diff. > > > > Thanks for the offer. Here is a diff against games/eboard with the = to > > changes: > > > > diff --git a/games/eboard/Makefile b/games/eboard/Makefile > > index 3f78f9e91874..ce399415cba8 100644 > > --- a/games/eboard/Makefile > > +++ b/games/eboard/Makefile > > @@ -20,10 +20,10 @@ LIB_DEPENDS=3D > > libfontconfig.so:x11-fonts/fontconfig \ > > libfreetype.so:print/freetype2 \ > > libpng.so:graphics/png > > > > -USES=3D compiler:c++11-lang gnome gstreamer perl5 pkgconf= ig > > shebangfix tar:bzip2 > > +USES=3D gnome gstreamer perl5 pkgconfig shebangfix tar:bz= ip2 > > # eboard 1.1.13 is not compatible with C++17, which is the > > default since > > # clang 16. This means ports depending on it also need to use at > > most > > C++14. > > -USE_CXXSTD=3D c++11 > > +USE_CXXSTD=3D c++14 > > USE_GITHUB=3D yes > > GH_ACCOUNT=3D fbergo > > USE_GNOME=3D cairo gdkpixbuf2 gtk20 > > > > > > It would be very nice if you could also look for arm, if the packag= e > is > > still binary compatible compared to the unpatched version :) > > > > Thanks a lot ! > > > > Best wishes, > > Rainer > > > > > > > > Cheers, > > > > > > -- > > > Nuno Teixeira > > > FreeBSD Committer (ports) > > > > > > > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > > --=20 Nuno Teixeira FreeBSD Committer (ports) --0000000000006259db05ffe3f3de Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div><span class=3D"gmail-im">PORTREVISION=3D11:=C2=A0 USE= _CXXSTD=3Dgnu++14</span></div><div><a href=3D"http://freebsdrpi4.hopto.org/= data/13Saarch64-main/2023-07-07_12h12m14s/logs/eboard-1.1.3_11.log">http://= freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_12h12m14s/logs/eboard= -1.1.3_11.log</a></div><div><br></div><div><span class=3D"gmail-im">PORTREV= ISION=3D10:=C2=A0 USE_CXXSTD=3Dc++14</span></div><div><a href=3D"http://fre= ebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_09h44m48s/logs/eboard-1.= 1.3_10.log">http://freebsdrpi4.hopto.org/data/13Saarch64-main/2023-07-07_09= h44m48s/logs/eboard-1.1.3_10.log</a></div><div><br></div><div>Both revs 10 = and 11 runs OK.</div><div><br></div><div>I've take a look at logs and i= t seems that glib2 deprecations could be the reason for c++17 build failure= s.</div><div>Could you take a look at:</div><div><a href=3D"https://cgit.fr= eebsd.org/ports/commit/?id=3De95c4bea425b3e3c49b63e0cf4eff24af40c574b">http= s://cgit.freebsd.org/ports/commit/?id=3De95c4bea425b3e3c49b63e0cf4eff24af40= c574b</a></div><div>it also includes link to mailing full discussion.</div>= <div><br></div><div>This is what we should do when possible, fix the code a= s said in previous messages.<br></div></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">Rainer Hurling <<a href=3D"mailto:= rhurlin@gwdg.de">rhurlin@gwdg.de</a>> escreveu no dia sexta, 7/07/2023 = =C3=A0(s) 10:53:<br></div><blockquote class=3D"gmail_quote" style=3D"margin= :0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"= >Am 07.07.23 um 10:59 schrieb Nuno Teixeira:<br> > Hello!<br> > <br> > I've bumped PORTREVISION to 10 so we can identify better each expe= riment <br> > build:<br> > <br> > PORTREVISION=3D10:=C2=A0 USE_CXXSTD=3Dc++14<br> > build status:<br> > <a href=3D"http://freebsdrpi4.hopto.org/build.html?mastername=3D13Saar= ch64-main&build=3D2023-07-07_09h44m48s" rel=3D"noreferrer" target=3D"_b= lank">http://freebsdrpi4.hopto.org/build.html?mastername=3D13Saarch64-main&= amp;build=3D2023-07-07_09h44m48s</a> <<a href=3D"http://freebsdrpi4.hopt= o.org/build.html?mastername=3D13Saarch64-main&build=3D2023-07-07_09h44m= 48s" rel=3D"noreferrer" target=3D"_blank">http://freebsdrpi4.hopto.org/buil= d.html?mastername=3D13Saarch64-main&build=3D2023-07-07_09h44m48s</a>>= ;<br> > <br> > and when built I will do a run test.<br> > <br> <br> Oops, yes!<br> <br> > Shoud I test gnu++14 too?<br> <br> I accidentally provided a patch with c++14 that I had used for another <br> test of my own. Meant was gnu++14, so please feel free to test that one <br= > too. Thanks!<br> <br> > <br> > <br> > <br> > <br> > Rainer Hurling <<a href=3D"mailto:rhurlin@gwdg.de" target=3D"_blank= ">rhurlin@gwdg.de</a> <mailto:<a href=3D"mailto:rhurlin@gwdg.de" target= =3D"_blank">rhurlin@gwdg.de</a>>> escreveu no <br> > dia sexta, 7/07/2023 =C3=A0(s) 06:42:<br> > <br> >=C2=A0 =C2=A0 =C2=A0Hi Nuno,<br> > <br> >=C2=A0 =C2=A0 =C2=A0Am 06.07.23 um 23:51 schrieb Nuno Teixeira:<br> >=C2=A0 =C2=A0 =C2=A0 > Hello Rainer,<br> >=C2=A0 =C2=A0 =C2=A0 ><br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0Still, one more question: = is it safe to remove<br> >=C2=A0 =C2=A0 =C2=A0USES=3Dcompiler:c++11-lang<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0for architectures other th= an amd64 and i386 and just use<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0USE_STDCXX=3Dgnu++14. I ha= ve no way to test for arm, etc.<br> >=C2=A0 =C2=A0 =C2=A0 ><br> >=C2=A0 =C2=A0 =C2=A0 ><br> >=C2=A0 =C2=A0 =C2=A0 > I've asked the same for compiler:c11 on m= ailing today.<br> >=C2=A0 =C2=A0 =C2=A0 > My doubt is: is it neccessary using c11, c++1= 1, etc when available<br> >=C2=A0 =C2=A0 =C2=A0 > compilers support it or have capabilities for= it?<br> >=C2=A0 =C2=A0 =C2=A0 ><br> >=C2=A0 =C2=A0 =C2=A0 > I can do poudriere testport and run test on a= rpi4 running 13<br> >=C2=A0 =C2=A0 =C2=A0stable,<br> >=C2=A0 =C2=A0 =C2=A0 > just send me diff.<br> > <br> >=C2=A0 =C2=A0 =C2=A0Thanks for the offer. Here is a diff against games/= eboard with the to<br> >=C2=A0 =C2=A0 =C2=A0changes:<br> > <br> >=C2=A0 =C2=A0 =C2=A0diff --git a/games/eboard/Makefile b/games/eboard/M= akefile<br> >=C2=A0 =C2=A0 =C2=A0index 3f78f9e91874..ce399415cba8 100644<br> >=C2=A0 =C2=A0 =C2=A0--- a/games/eboard/Makefile<br> >=C2=A0 =C2=A0 =C2=A0+++ b/games/eboard/Makefile<br> >=C2=A0 =C2=A0 =C2=A0@@ -20,10 +20,10 @@ LIB_DEPENDS=3D<br> >=C2=A0 =C2=A0 =C2=A0libfontconfig.so:x11-fonts/fontconfig \<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0libfreetype.so:print/freetype2 \<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0libpng.so:graphics/png<br> > <br> >=C2=A0 =C2=A0 =C2=A0-USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler= :c++11-lang gnome gstreamer perl5 pkgconfig<br> >=C2=A0 =C2=A0 =C2=A0shebangfix tar:bzip2<br> >=C2=A0 =C2=A0 =C2=A0+USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gnome gs= treamer perl5 pkgconfig shebangfix tar:bzip2<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 # eboard 1.1.13 is not compatible with C++1= 7, which is the<br> >=C2=A0 =C2=A0 =C2=A0default since<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 # clang 16. This means ports depending on i= t also need to use at<br> >=C2=A0 =C2=A0 =C2=A0most<br> >=C2=A0 =C2=A0 =C2=A0C++14.<br> >=C2=A0 =C2=A0 =C2=A0-USE_CXXSTD=3D=C2=A0 =C2=A0 c++11<br> >=C2=A0 =C2=A0 =C2=A0+USE_CXXSTD=3D=C2=A0 =C2=A0 c++14<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 USE_GITHUB=3D=C2=A0 =C2=A0 yes<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 GH_ACCOUNT=3D=C2=A0 =C2=A0 fbergo<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 USE_GNOME=3D=C2=A0 =C2=A0 =C2=A0cairo gdkpi= xbuf2 gtk20<br> > <br> > <br> >=C2=A0 =C2=A0 =C2=A0It would be very nice if you could also look for ar= m, if the package is<br> >=C2=A0 =C2=A0 =C2=A0still binary compatible compared to the unpatched v= ersion :)<br> > <br> >=C2=A0 =C2=A0 =C2=A0Thanks a lot !<br> > <br> >=C2=A0 =C2=A0 =C2=A0Best wishes,<br> >=C2=A0 =C2=A0 =C2=A0Rainer<br> > <br> >=C2=A0 =C2=A0 =C2=A0 ><br> >=C2=A0 =C2=A0 =C2=A0 > Cheers,<br> >=C2=A0 =C2=A0 =C2=A0 ><br> >=C2=A0 =C2=A0 =C2=A0 > --<br> >=C2=A0 =C2=A0 =C2=A0 > Nuno Teixeira<br> >=C2=A0 =C2=A0 =C2=A0 > FreeBSD Committer (ports)<br> > <br> > <br> > <br> > -- <br> > Nuno Teixeira<br> > FreeBSD Committer (ports)<br> <br> </blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre= fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l= tr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committ= er (ports)</span></div></div> --0000000000006259db05ffe3f3de--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJ90-hVX3WePtD--tHb0HEeUrq6Y0mRezZ8kYYoDQL69g>