From owner-freebsd-arch@FreeBSD.ORG Thu Jun 4 20:07:39 2009 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07E8C106564A for ; Thu, 4 Jun 2009 20:07:39 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id CFEA78FC1A for ; Thu, 4 Jun 2009 20:07:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 6B4D546B2C; Thu, 4 Jun 2009 16:07:38 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 5D5088A040; Thu, 4 Jun 2009 16:07:37 -0400 (EDT) From: John Baldwin To: freebsd-arch@freebsd.org Date: Thu, 4 Jun 2009 15:19:47 -0400 User-Agent: KMail/1.9.7 References: <20090604.121611.1057477291.imp@bsdimp.com> In-Reply-To: <20090604.121611.1057477291.imp@bsdimp.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200906041519.47552.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Thu, 04 Jun 2009 16:07:37 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Subject: Re: HEADS UP: Removing functions from driver API X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2009 20:07:39 -0000 On Thursday 04 June 2009 2:16:11 pm M. Warner Losh wrote: > I'd like to remove from the driver API by making the following static: > devclass_add_driver > devclass_delete_driver > devclass_find_driver > > They aren't used, nor generally useful, by drivers in the current > tree. The devclass_t routines are generally harder to lock than > necessary because they touch so much global data. By eliminating > these from the API, its three fewer functions that need to be robustly > locked for external consumers. Since they are basically unused today > anyway, I think it would be better to just reduce their scope. > > Comments? Go for it. -- John Baldwin