From owner-svn-src-all@FreeBSD.ORG Sun Sep 27 14:55:11 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5889B106566B; Sun, 27 Sep 2009 14:55:11 +0000 (UTC) (envelope-from simon@nitro.dk) Received: from mx.nitro.dk (zarniwoop.nitro.dk [83.92.207.38]) by mx1.freebsd.org (Postfix) with ESMTP id 0F8AB8FC13; Sun, 27 Sep 2009 14:55:11 +0000 (UTC) Received: from arthur.nitro.dk (arthur.bofh [192.168.2.3]) by mx.nitro.dk (Postfix) with ESMTP id 63BD42D48A1; Sun, 27 Sep 2009 14:55:10 +0000 (UTC) Received: by arthur.nitro.dk (Postfix, from userid 1000) id 4F3AC5C05; Sun, 27 Sep 2009 16:55:10 +0200 (CEST) Date: Sun, 27 Sep 2009 16:55:10 +0200 From: "Simon L. Nielsen" To: Alexey Dokuchaev Message-ID: <20090927145509.GG1495@arthur.nitro.dk> References: <200909251824.n8PIOLte036513@svn.freebsd.org> <20090925191416.GA1597@garage.freebsd.pl> <86tyyph1jl.fsf@ds4.des.no> <20090927070220.GA18022@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090927070220.GA18022@FreeBSD.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: src-committers@freebsd.org, Pawel Jakub Dawidek , svn-src-all@freebsd.org, Thomas Backman , svn-src-head@freebsd.org, Dag-Erling Sm??rgrav Subject: Re: svn commit: r197498 - head/cddl/contrib/opensolaris/cmd/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Sep 2009 14:55:11 -0000 On 2009.09.27 07:02:21 +0000, Alexey Dokuchaev wrote: > On Sat, Sep 26, 2009 at 10:51:58PM +0200, Dag-Erling Sm??rgrav wrote: > > Pawel Jakub Dawidek writes: > > > I didn't, thanks. Unfortunately svn doesn't even allow forced commits, > > > which is a paintful regression compared to cvs. > > > > Subversion does allow editing a log message after the fact, but our > > commit scripts prohibit it. This should IMHO be allowed, and cause a > > new email to be sent out to note the change. > > I recall that one of the reasons behind prohibition was to avoid issues > with CVS exporter. I doubt the CVS exporter would have a problem, though I'm not 100% sure. I think the problem is more that svnsync does not pick up the change, but des knows more about that than I do. PS. I don't personally have a problem allowing people to edit commit messages, as long as it's "visible" and we knows what the side-effects are. -- Simon L. Nielsen