From owner-freebsd-ppc@FreeBSD.ORG Wed Mar 24 02:02:59 2010 Return-Path: Delivered-To: powerpc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48C161065673; Wed, 24 Mar 2010 02:02:59 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout027.mac.com (asmtpout027.mac.com [17.148.16.102]) by mx1.freebsd.org (Postfix) with ESMTP id 2C3958FC19; Wed, 24 Mar 2010 02:02:58 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=us-ascii Received: from macbook-pro.lan.xcllnt.net (mail.xcllnt.net [75.101.29.67]) by asmtp027.mac.com (Sun Java(tm) System Messaging Server 6.3-8.01 (built Dec 16 2008; 32bit)) with ESMTPSA id <0KZR009O3KCS1V80@asmtp027.mac.com>; Tue, 23 Mar 2010 19:02:54 -0700 (PDT) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=5.0.0-0908210000 definitions=main-1003230307 From: Marcel Moolenaar In-reply-to: <20100324003846.GK1278@michelle.cdnetworks.com> Date: Tue, 23 Mar 2010 19:02:52 -0700 Message-id: <1E7B1B12-A426-419D-874C-3BBDF7DE0698@mac.com> References: <4BA8CF0E.50201@freebsd.org> <20100323.094126.787670930724128348.imp@bsdimp.com> <20100323230351.GI1278@michelle.cdnetworks.com> <00BE3C94-8C04-4E00-9617-1DB07C7FAF42@mac.com> <20100324003846.GK1278@michelle.cdnetworks.com> To: pyunyh@gmail.com X-Mailer: Apple Mail (2.1077) Cc: powerpc@freebsd.org, embedded@freebsd.org, "M. Warner Losh" Subject: Re: Anyone using BOOTP with latest current (Book-E)? X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 02:02:59 -0000 On Mar 23, 2010, at 5:38 PM, Pyun YongHyeon wrote: >> What the patch does is to not enable autoneg when autoneg is already >> enabled so that we don't interfere with the autoneg handshake. >> > > Yeah, but it also disables ability to restart auto-negotiation with > "ifconfig tsec0 media auto" command. That's a valid point. Unfortunately, it's also the problem in a way. I have one too many FreeBSD machines unable to boot normally into multi-user mode simply because of excessive link flaps by virtue of running ifconfig. > If the PHY is buggy I would add a special case not to check the > CIPHY_BMSR_ACOMP bit of BMCR for a give PHY model in auto-negotiation > completion check. The PHY isn't buggy. At least not that I'm aware of :-) > One odd thing in tsec(4) is tsec_miibus_statchg() handling. If > ciphy(4) just reports link UP, tsec(4) still seems to reprogram > TSEC_REG_ECNTRL register. Shouldn't it check link UP state as well > as resolved speed/duplex of link? It does check the speed of the link. > Also I'm not sure whether tsec(4) > can safely change duplex configuration when MAC is in > enabled/active state. Extensive testing has been done to validate proper operation of the driver WRT link (re-)negotiations. While Juniper's version is a bit different from FreeBSD's version, tsec_miibus_statchg() is fundamentally the same (only locking differences and style). -- Marcel Moolenaar xcllnt@mac.com