From owner-freebsd-current@FreeBSD.ORG  Wed Apr 29 11:58:12 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EBAF4106564A
	for <current@freebsd.org>; Wed, 29 Apr 2009 11:58:12 +0000 (UTC)
	(envelope-from ben@wanderview.com)
Received: from mail.wanderview.com (mail.wanderview.com [66.92.166.102])
	by mx1.freebsd.org (Postfix) with ESMTP id 905348FC13
	for <current@freebsd.org>; Wed, 29 Apr 2009 11:58:12 +0000 (UTC)
	(envelope-from ben@wanderview.com)
Received: from harkness.in.wanderview.com (harkness.in.wanderview.com
	[10.76.10.150]) (authenticated bits=0)
	by mail.wanderview.com (8.14.3/8.14.3) with ESMTP id n3TBw5XT002337
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Wed, 29 Apr 2009 11:58:06 GMT (envelope-from ben@wanderview.com)
Message-Id: <A83EA714-1EB5-41C1-91E2-FD031FD0DE0E@wanderview.com>
From: Ben Kelly <ben@wanderview.com>
To: Jaakko Heinonen <jh@saunalahti.fi>
In-Reply-To: <20090429064303.GA2189@a91-153-125-115.elisa-laajakaista.fi>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v930.3)
Date: Wed, 29 Apr 2009 07:58:05 -0400
References: <AC3C4C3F-40C6-4AF9-BAF3-2C4D1E444839@wanderview.com>
	<ed91d4a80904142135n429dea52o672abf51116fa707@mail.gmail.com>
	<ed91d4a80904241816r28531a04r2dc70fa8960d430e@mail.gmail.com>
	<bc2d970904241947r50576efbgc93164a9e4dd297d@mail.gmail.com>
	<ed91d4a80904242059n3642a40aud55df6d1b6a1695@mail.gmail.com>
	<FC83DB1E-6C08-4BD4-8BC9-437D714FEE9E@wanderview.com>
	<ed91d4a80904271839l49420c8rbcfd52dd6e72eb83@mail.gmail.com>
	<ed91d4a80904281111q3b9a3c45vc9fcf129dde8c10d@mail.gmail.com>
	<F86D3461-3ABD-4A56-B9A6-36857364DF4B@wanderview.com>
	<4D8E4457-89AA-4F19-9960-E090D3B8E319@wanderview.com>
	<20090429064303.GA2189@a91-153-125-115.elisa-laajakaista.fi>
X-Mailer: Apple Mail (2.930.3)
X-Spam-Score: -1.44 () ALL_TRUSTED
X-Scanned-By: MIMEDefang 2.64 on 10.76.20.1
Cc: current@freebsd.org
Subject: Re: [patch] zfs livelock and thread priorities
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2009 11:58:13 -0000

On Apr 29, 2009, at 2:43 AM, Jaakko Heinonen wrote:
> On 2009-04-28, Ben Kelly wrote:
>>> http://www.wanderview.com/svn/public/misc/zfs/zfs_zinactive_deadlock.diff
>>
>> The patch is updated in the same location above.
>
> There's a fatal typo in the patch:
>
> -	ZFS_OBJ_HOLD_ENTER(zfsvfs, z_id);
> +	locked == ZFS_OBJ_HOLD_TRYENTER(zfsvfs, z_id);
>              ^^^^

Yikes!  Thanks for catching this!

The patch has been updated at the same URL.  If anyone has patched  
their system please grab the new version.  Sorry for the confusion.

- Ben