From nobody Mon May 22 23:18:34 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QQD0F5Hwpz4CZvj; Mon, 22 May 2023 23:18:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QQD0F4qfbz4Qj8; Mon, 22 May 2023 23:18:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684797517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r3em1INcx6hTyMO1coO4C06ReRJcBW0cMVvmpNhw3XM=; b=xIBOdmS7WGeu8+F+dk6uWm4GkRo+XKf86VkS/Qem5+m4Uuq/oqYGcXmkP9qrUlJIH9xAuT tX61lfRQrkL0GmJK4wRbkXtBOvJ993KjF7kOx4x0Jwt6d7G6CyhNCebBYHKVIIKv0SX5YM uIq6c/HYjbxYrpuR0Vfa0g0Rh6xfVh9PrlmUJlSHOKch+X7pRlGLCFkzGM8TeI9EjBolXl EUxR/WfLz2rCBADnoVdU1tWuTxJJHSN5pu0yjXp6KnIeZ5uX2WLNhIDnxpySTpz9rbqsSf tdvlcUz8N0mjbijncIm6SCHdMEDYXfVyXxYdKYWMEhrakxNe+BlBnvQZbC8w5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684797517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r3em1INcx6hTyMO1coO4C06ReRJcBW0cMVvmpNhw3XM=; b=awdTEzoHRga05G/VVTymm3+MOGzwbap1ktW/cphLxpRu4pHTWKdsigwyVCCdCG2LJa7H+g NqU41uphjVJkDoiF4v9zwYUNL6Wh058NzHJTQniY0xVovgvqXLjvqIXNtV/emYeNidNO/w Ltg5/SMKOwiGHT+fqjz6nN1QFm1Lc8KidwZEmZtbVuab9qeILK0l3VLwBksLwEg+lnkFL6 dxHDQ24/BkNRJR3zYCf7n0qd/zrPkkyJJ+T3ozBoO1BqU5s+WN1Hbirwr66cTOEIVvAuj7 UC5GWoVfdG5wfzyfOK6eQTfpwienB4a1hkPVPAszfYH0l4QFrfAZrrduDiPr4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684797517; a=rsa-sha256; cv=none; b=w068WFizJdR2wMk2yii0hNauvb41kbqe2NSh+OJ7K6UHYurckTlV0jye7VoAptLmhC3jts AdmJR1FmqA6Lpdbr76V3QkYIa/VhrCwYZyUoq88/0evmDAdpew74oF7DW5TCZg08SIHiBL edSYApSKGrpRRbLhwDUfw5pv0c0gLeuoC+9OkYlhGyl4syDB7PWbIgmOso3kLdJHelnpsa GG60zF4w4brTRTB0NMgYYqxD6NI+iX6JzDl/j+Aa/FydrGthTPupvlRgvqrhbtKimw5PfG oUYGTzrv3oFYpNkqL7rMiB6cpctAKlxM2QVlOB/vFs521mrb+LLWaVlrmM4yDw== Received: from [IPV6:2601:648:8680:16b0:79e8:c02e:291a:4408] (unknown [IPv6:2601:648:8680:16b0:79e8:c02e:291a:4408]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QQD0F0DVWzG8J; Mon, 22 May 2023 23:18:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <91aa828c-fa59-3d53-f801-baa43ffba135@FreeBSD.org> Date: Mon, 22 May 2023 16:18:34 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: git: ccb59683b983 - main - arm64: add tests for swp/swpb emulation Content-Language: en-US To: Jessica Clarke , Kyle Evans Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202305151542.34FFgONF071780@gitrepo.freebsd.org> <663D9FB2-D1EF-4D51-9FB1-038AF6AA98C0@freebsd.org> From: John Baldwin In-Reply-To: <663D9FB2-D1EF-4D51-9FB1-038AF6AA98C0@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 5/15/23 2:59 PM, Jessica Clarke wrote: > On 15 May 2023, at 16:42, Kyle Evans wrote: >> >> The branch main has been updated by kevans: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=ccb59683b98360afaf5b5bb641a68fea22c68d0b >> >> commit ccb59683b98360afaf5b5bb641a68fea22c68d0b >> Author: Kyle Evans >> AuthorDate: 2023-05-15 15:42:16 +0000 >> Commit: Kyle Evans >> CommitDate: 2023-05-15 15:42:16 +0000 >> >> arm64: add tests for swp/swpb emulation >> >> One test is suitable to be hooked up to the build, so I've done this >> here. The other test lives in tools/regression because failure is a >> bit more subjective -- generally, one runs it for some unbounded amount >> of time and observe if it eventually exits because two threads acquired >> the same mutex. >> >> Reviewed by: imp, mmel >> Sponsored by: Stormshield >> Sponsored by: Klara, Inc. >> Differential Revision: https://reviews.freebsd.org/D39668 >> --- >> etc/mtree/BSD.tests.dist | 2 + >> tests/sys/Makefile | 1 + >> tests/sys/compat32/Makefile | 6 + >> tests/sys/compat32/Makefile.inc | 4 + >> tests/sys/compat32/aarch64/Makefile | 24 ++ >> tests/sys/compat32/aarch64/common.sh | 9 + >> tests/sys/compat32/aarch64/swp_cond_test.sh | 14 + >> tests/sys/compat32/aarch64/swp_cond_test_impl.S | 413 ++++++++++++++++++++++ >> tests/sys/compat32/aarch64/swp_test.sh | 14 + >> tests/sys/compat32/aarch64/swp_test_impl.S | 216 +++++++++++ >> tools/regression/compat32/aarch64/Makefile | 4 + >> tools/regression/compat32/aarch64/swp_test_impl.S | 410 +++++++++++++++++++++ >> 12 files changed, 1117 insertions(+) >> >> ... >> diff --git a/tests/sys/compat32/aarch64/Makefile b/tests/sys/compat32/aarch64/Makefile >> new file mode 100644 >> index 000000000000..716182b15d9c >> --- /dev/null >> +++ b/tests/sys/compat32/aarch64/Makefile >> @@ -0,0 +1,24 @@ >> +PACKAGE= tests >> +FILESGROUPS+= asmprogs >> + >> +ACFLAGS= -target armv7-unknown-freebsd${OS_REVISION} -nostdlib -Wl,-e -Wl,main -static > > This won’t work with GCC, nor will it work with an LLVM built with only > AArch64 enabled as a target (e.g. -DWITHOUT_LLVM_TARGET_ALL > -DWITHOUT_LLVM_TARGET_ARM; latter is needed since we do default to > enabling ARM if AArch64 is even for a cut-down toolchain so that -m32 > works). This is why the freebsd32 sigcode in arm64 kernels is written > as hex (with disassembly comments) rather than assembled from proper > source. I haven't managed to get either 32-bit or 64-bit arm fully building with GCC FWIW. I think it can be fine to require that a system compiler for arm64 support -m32. We de-facto require such for amd64 already. -- John Baldwin