From owner-freebsd-current@FreeBSD.ORG  Fri Jan 31 22:51:00 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7EC88ECA;
 Fri, 31 Jan 2014 22:51:00 +0000 (UTC)
Received: from mta04.bitpro.no (mta04.bitpro.no [92.42.64.203])
 by mx1.freebsd.org (Postfix) with ESMTP id 3249011B8;
 Fri, 31 Jan 2014 22:50:59 +0000 (UTC)
Received: from mail.lockless.no (mail.lockless.no [46.29.221.38])
 by mta04.bitpro.no (Postfix) with ESMTPS id 4F1FF10020F;
 Fri, 31 Jan 2014 23:50:58 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by mail.lockless.no (Postfix) with ESMTP id C1CBF180148;
 Fri, 31 Jan 2014 23:49:39 +0100 (CET)
X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at lockless.no
Received: from mail.lockless.no ([127.0.0.1])
 by localhost (mail.lockless.no [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id BubaJfuvW8Q1; Fri, 31 Jan 2014 23:49:38 +0100 (CET)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 by mail.lockless.no (Postfix) with ESMTPSA id C6318180135;
 Fri, 31 Jan 2014 23:49:38 +0100 (CET)
Message-ID: <52EC2889.9020107@bitfrost.no>
Date: Fri, 31 Jan 2014 23:49:45 +0100
From: Hans Petter Selasky <hps@bitfrost.no>
Organization: Bitfrost A/S
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: "Danilo E. Gondolfo" <danilo@freebsd.org>, 
 freebsd-current@freebsd.org, =?UTF-8?B?6buE5paH6L6J?= <huanghwh@gmail.com>
Subject: Re: Apple Trackpad driver
References: <CAB8uncaLEn4CaJv8+owESe_zUUK+gem_bXpEjhsOJE69m_fWAg@mail.gmail.com>
 <CAJ-Vmon4Gk6bqoT+Jf-bRxE0+NJ1NjR0wjum-HjoVFDN-2e=8Q@mail.gmail.com>
 <CAASDrV=pbDpZCGvEjnD8VS0D_HyC8=L3jQ7rfGszG6=PtxaE3Q@mail.gmail.com>
 <CAASDrVmqijq51OEH7USLutPSgme7YWhXZZX4tGROLHVPoz2VkA@mail.gmail.com>
 <52E8DDA3.3070301@bitfrost.no>
 <CAB8uncZVCbFWhJrEosRtRebRip4HjArsZx9FwKE0q9EjYDncmg@mail.gmail.com>
 <52E9F546.9090005@bitfrost.no>
 <CAB8unca0ViSrg9ExGX+sEfQta9AAXbkKoaGr8RLX1-ksay2tog@mail.gmail.com>
 <52EB4DBE.20501@bitfrost.no> <52EC07CE.70608@freebsd.org>
In-Reply-To: <52EC07CE.70608@freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Jan 2014 22:51:00 -0000

On 01/31/14 21:30, Danilo E. Gondolfo wrote:
> On 01/31/14 05:16, Hans Petter Selasky wrote:
>> On 01/31/14 02:46, Huang Wen Hui wrote:
>>> Hi Hans,
>>>
>>> pos_x[] is not non-inialized,  it may be previous pos_x, it is still
>>> ok for
>>> getting dx.
>>> "n" var is trying to reduce "untouch" sensor data for post
>>> proccessing. I
>>> attach a new patch
>>> may be more clear, also fixed unexpected movement when button status or
>>> ntouch changing.
>>>
>>> Cheers,
>>>
>>> Huang Wen Hui
>>
>> Hi,
>>
>> http://svnweb.freebsd.org/changeset/base/261315
>>
>> --HPS
>>
>
> Good work!
>
> I noticed that your driver is based on the Linux driver [1] and some
> pieces of code are copied, are you sure that we won't have any problems
> with license?
>
> These changes can be (should be) merged in the driver atp(4), no?
>
> Danilo.
>
>
> [1] - http://lxr.free-electrons.com/source/drivers/input/mouse/bcm5974.c

Hi,

It looks to me like some tables have been copied. We probably should add 
a notice about that. The rest of the code looks OK to me.

Huang, any comments?

--HPS